Skip to content

Detect when wasmtime is not installed in Tools/wasm/wasi.py #121521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brettcannon opened this issue Jul 9, 2024 · 0 comments
Closed

Detect when wasmtime is not installed in Tools/wasm/wasi.py #121521

brettcannon opened this issue Jul 9, 2024 · 0 comments
Assignees
@brettcannon
Labels
OS-wasi type-feature A feature request or enhancement

Comments

@brettcannon
Copy link
Member

brettcannon commented Jul 9, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

Right now, Tools/wasm/wasi.py calls shutil.which() at the global level of the file. That means you can end up w/ None in your HOSTRUNNER environment variable.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs
@brettcannon brettcannon added type-feature A feature request or enhancement OS-wasi labels Jul 9, 2024
@brettcannon brettcannon self-assigned this Jul 9, 2024
brettcannon added a commit to brettcannon/cpython that referenced this issue Jul 9, 2024
@brettcannon
pythonGH-121521: Detect when wasmtime is not installed in `Tools/wasm…
ce896b7 
…/wasi.py`
@bedevere-app bedevere-app bot mentioned this issue Jul 9, 2024
Merged
brettcannon added a commit that referenced this issue Jul 9, 2024
@brettcannon
GH-121521: Detect when wasmtime is not installed in `Tools/wasm/wasi.…
f621618 
…py` (GH-121522)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 9, 2024
@brettcannon @miss-islington
pythonGH-121521: Detect when wasmtime is not installed in `Tools/wasm…
b8449fd 
…/wasi.py` (pythonGH-121522)

(cherry picked from commit f621618)

Co-authored-by: Brett Cannon <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jul 9, 2024
Merged
brettcannon added a commit that referenced this issue Jul 9, 2024
@miss-islington @brettcannon
[3.13] GH-121521: Detect when wasmtime is not installed in `Tools/was…
3824dc9 
…m/wasi.py` (GH-121522) (GH-121558)

GH-121521: Detect when wasmtime is not installed in `Tools/wasm/wasi.py` (GH-121522)
(cherry picked from commit f621618)

Co-authored-by: Brett Cannon <[email protected]>
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@brettcannon @noahbkim
pythonGH-121521: Detect when wasmtime is not installed in `Tools/wasm…
3804592 
…/wasi.py` (pythonGH-121522)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@brettcannon @estyxx
pythonGH-121521: Detect when wasmtime is not installed in `Tools/wasm…
53bf8f8 
…/wasi.py` (pythonGH-121522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brettcannon brettcannon

Labels
OS-wasi type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brettcannon