Skip to content

PyREPL: Completion menu does not get updated when inserting a character #120041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lysnikolaou opened this issue Jun 4, 2024 · 0 comments
Closed

PyREPL: Completion menu does not get updated when inserting a character #120041

lysnikolaou opened this issue Jun 4, 2024 · 0 comments
Assignees
@lysnikolaou
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes topic-repl Related to the interactive shell type-bug An unexpected behavior, bug, or error

Comments

@lysnikolaou
Copy link
Member

lysnikolaou commented Jun 4, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

The completions menu does not get updated when inserting a character. In a related matter, if one clicks Tab once when there's multiple possible completion a [ not unique ] message apperas. If someone presses another key there, instead of pressing Tab a second time, it messes up the cursor and appends the pressed character after the message.

CPython versions tested on:

3.13, CPython main branch

Operating systems tested on:

Linux, macOS

Linked PRs
@lysnikolaou lysnikolaou added type-bug An unexpected behavior, bug, or error 3.13 bugs and security fixes 3.14 bugs and security fixes topic-repl Related to the interactive shell labels Jun 4, 2024
@lysnikolaou lysnikolaou self-assigned this Jun 4, 2024
lysnikolaou added a commit to lysnikolaou/cpython that referenced this issue Jun 4, 2024
@lysnikolaou
pythongh-120041: Do not use append_to_screen when completions are vis…
14de78a 
…ible
@bedevere-app bedevere-app bot mentioned this issue Jun 4, 2024
Merged
ambv pushed a commit that referenced this issue Jun 4, 2024
@lysnikolaou
gh-120041: Do not use append_to_screen when completions are visible (G…
8fc7653 
…H-120042)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 4, 2024
@lysnikolaou @miss-islington
pythongh-120041: Do not use append_to_screen when completions are vis…
9fbf9bf 
…ible (pythonGH-120042)

(cherry picked from commit 8fc7653)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jun 4, 2024
Merged
lysnikolaou added a commit to lysnikolaou/cpython that referenced this issue Jun 4, 2024
@lysnikolaou
pythongh-120041: Refactor check for visible completion menu in comple…
189a4b6 
…ting_reader
@bedevere-app bedevere-app bot mentioned this issue Jun 4, 2024
Merged
lysnikolaou added a commit that referenced this issue Jun 4, 2024
@lysnikolaou
gh-120041: Refactor check for visible completion menu in completing_r…
bf8e5e5 
…eader (#120055)
lysnikolaou added a commit to miss-islington/cpython that referenced this issue Jun 4, 2024
@lysnikolaou
pythongh-120041: Refactor check for visible completion menu in comple…
ea33a03 
…ting_reader (python#120055)
lysnikolaou added a commit that referenced this issue Jun 4, 2024
@miss-islington @lysnikolaou
[3.13] gh-120041: Do not use append_to_screen when completions are vi…
8d74eae 
…sible (GH-120042) (#120051)

* gh-120041: Do not use append_to_screen when completions are visible (GH-120042)
(cherry picked from commit 8fc7653)

* gh-120041: Refactor check for visible completion menu in completing_reader (GH-120055)
(cherry picked from commit bf8e5e5)
---------

Co-authored-by: Lysandros Nikolaou <[email protected]>
barneygale pushed a commit to barneygale/cpython that referenced this issue Jun 5, 2024
@lysnikolaou @barneygale
pythongh-120041: Do not use append_to_screen when completions are vis…
fbef7b9 
…ible (pythonGH-120042)
barneygale pushed a commit to barneygale/cpython that referenced this issue Jun 5, 2024
@lysnikolaou @barneygale
pythongh-120041: Refactor check for visible completion menu in comple…
bb615c6 
…ting_reader (python#120055)
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@lysnikolaou @noahbkim
pythongh-120041: Do not use append_to_screen when completions are vis…
fd3d4ce 
…ible (pythonGH-120042)
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@lysnikolaou @noahbkim
pythongh-120041: Refactor check for visible completion menu in comple…
45c9c89 
…ting_reader (python#120055)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@lysnikolaou @estyxx
pythongh-120041: Do not use append_to_screen when completions are vis…
34dbbbf 
…ible (pythonGH-120042)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@lysnikolaou @estyxx
pythongh-120041: Refactor check for visible completion menu in comple…
8330c09 
…ting_reader (python#120055)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lysnikolaou lysnikolaou

Labels
3.13 bugs and security fixes 3.14 bugs and security fixes topic-repl Related to the interactive shell type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lysnikolaou