Skip to content

Fix new Tkinter tests for wantobjects=0 #119791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
serhiy-storchaka opened this issue May 30, 2024 · 0 comments
Closed

Fix new Tkinter tests for wantobjects=0 #119791

serhiy-storchaka opened this issue May 30, 2024 · 0 comments
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes tests Tests in the Lib/test dir topic-tkinter

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented May 30, 2024

Some of recently added Tkinter tests for PhotoImage do not pass if tkinter.wantobjects=0, because PhotoImage.get() returns a string like "255 0 0" instead of a 3-tuple of integers like (255, 0, 0).

Other solution is to make PhotoImage.get() always returning a 3-tuple of integers, and it is a correct solution, but I am not sure that it can be backported. It can break the code that uses tkinter.wantobjects=0 and manually parses the returned string.

Linked PRs

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir topic-tkinter 3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes labels May 30, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue May 30, 2024
PhotoImage.get() retruns a string instead of a 3-tuple of integers
in this case.
serhiy-storchaka added a commit that referenced this issue May 30, 2024
PhotoImage.get() retruns a string instead of a 3-tuple of integers
in this case.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 30, 2024
…9792)

PhotoImage.get() retruns a string instead of a 3-tuple of integers
in this case.
(cherry picked from commit e875c2d)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue May 30, 2024
…onGH-119792)

PhotoImage.get() retruns a string instead of a 3-tuple of integers
in this case.
(cherry picked from commit e875c2d)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka removed the 3.12 only security fixes label May 30, 2024
serhiy-storchaka added a commit that referenced this issue May 30, 2024
…GH-119794)

PhotoImage.get() retruns a string instead of a 3-tuple of integers
in this case.
(cherry picked from commit e875c2d)

Co-authored-by: Serhiy Storchaka <[email protected]>
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
…9792)

PhotoImage.get() retruns a string instead of a 3-tuple of integers
in this case.
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
…9792)

PhotoImage.get() retruns a string instead of a 3-tuple of integers
in this case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes tests Tests in the Lib/test dir topic-tkinter
Projects
None yet
Development

No branches or pull requests

1 participant