Skip to content

Could not build CPython locally after #118307 #119736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zheaoli opened this issue May 29, 2024 · 3 comments
Closed

Could not build CPython locally after #118307 #119736

Zheaoli opened this issue May 29, 2024 · 3 comments
Assignees
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes build The build process and cross-build pending The issue will be closed if no feedback is provided topic-JIT

Comments

@Zheaoli
Copy link
Contributor

Zheaoli commented May 29, 2024

Bug report

Bug description:

After #118307 , the developer needs to install LLVM 18 if they want to build CPython locally. But LLVM <= 17 is the most commonly used version in a lot of distributions of Linux( Like Ubuntu, Arch, Fedora)

I propose to add new environment variables like PYTHON_JIT_LLVM_VERSION to allow people override the default LLVM version requirement locally

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

@Zheaoli Zheaoli added the type-bug An unexpected behavior, bug, or error label May 29, 2024
@Zheaoli
Copy link
Contributor Author

Zheaoli commented May 29, 2024

cc @brandtbucher

@AlexWaygood AlexWaygood added the build The build process and cross-build label May 29, 2024
@ned-deily
Copy link
Member

Just to clarify, LLVM (other than just clang) is only required if you are building 3.13+ with the experimental just-in-time compiler feature enabled (--enable-experimental-jit). And, as documented in the JIT README in the cpython repo, "LLVM version 18 is required". If you are not experimenting with the JIT feature, compiler build requirements for 3.13+ have not changed, i.e. LLVM is not required.

@terryjreedy terryjreedy added pending The issue will be closed if no feedback is provided and removed type-bug An unexpected behavior, bug, or error labels May 29, 2024
@brandtbucher
Copy link
Member

Yep. @Zheaoli, do you mind clarifying your issue further? Users won't need an LLVM install ever, and people building the interpreter only need LLVM to build the optional, experimental JIT.

It's not incredibly difficult to allow more versions (the current code actually works fine if you change a single 18 constant to a 17 or 19 in the build script), but for CI and support reasons I would like to avoid allowing more versions "just because we can". In fact, we are probably going to be targeting LLVM 19 for the 3.14 release once that's out, since it has some additional features that we'd like to use.

If you still believe that the current LLVM requirement is a burden, then maybe we can move the discussion to GH-115869.

@brandtbucher brandtbucher self-assigned this May 29, 2024
@brandtbucher brandtbucher added 3.13 bugs and security fixes 3.14 bugs and security fixes labels May 29, 2024
@hauntsaninja hauntsaninja closed this as not planned Won't fix, can't repro, duplicate, stale Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes build The build process and cross-build pending The issue will be closed if no feedback is provided topic-JIT
Projects
None yet
Development

No branches or pull requests

6 participants