Argument Clinic does not check for errors in PyBuffer_FillInfo in generated code

[sobolevn]

Bug report

AC generates:

• cpython/Modules/clinic/_codecsmodule.c.h

  Line 300 in 39ec7fb

  PyBuffer_FillInfo(&data, args[0], (void *)ptr, len, 1, 0);

• cpython/Modules/clinic/_codecsmodule.c.h

  Line 1102 in 39ec7fb

  PyBuffer_FillInfo(&data, args[0], (void *)ptr, len, 1, 0);

• cpython/Modules/clinic/_codecsmodule.c.h

  Line 1178 in 39ec7fb

  PyBuffer_FillInfo(&data, args[0], (void *)ptr, len, 1, 0);

• cpython/Modules/clinic/_codecsmodule.c.h

  Line 1647 in 39ec7fb

  PyBuffer_FillInfo(&data, args[0], (void *)ptr, len, 1, 0);

• cpython/Modules/clinic/_ssl.c.h

  Line 1300 in 39ec7fb

  PyBuffer_FillInfo(&view, args[0], (void *)ptr, len, 1, 0);

However, PyBuffer_FillInfo can raise errors and return -1 on multiple occasions, so it is not safe to not check for it.

I have a PR ready.

Linked PRs

• gh-115026: AC should generate code that checks for errors of PyBuffer_FillInfo #115027

[serhiy-storchaka]

PyBuffer_FillInfo() can only set an error if view is NULL or flags has invalid value. Both are impossible in Argument Clinic generated code which passes an address of a local variable as view and PyBUF_SIMPLE as flags.

[erlend-aasland]

Thanks!