Skip to content

test_winconsoleio prints unnecessary information #114561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Eclips4 opened this issue Jan 25, 2024 · 2 comments
Closed

test_winconsoleio prints unnecessary information #114561

Eclips4 opened this issue Jan 25, 2024 · 2 comments
Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes OS-windows tests Tests in the Lib/test dir

Comments

@Eclips4
Copy link
Member

Eclips4 commented Jan 25, 2024

Bug report

Bug description:

./python -m test -v test_winconsoleio                      
Running Debug|x64 interpreter...                                                                       
== CPython 3.13.0a3+ (heads/main:07ef63fb6a, Jan 25 2024, 18:36:12) [MSC v.1933 64 bit (AMD64)]        
== Windows-10-10.0.19043-SP0 little-endian                                                             
== Python build: debug                                                                                 
== cwd: C:\Users\KIRILL-1\CLionProjects\cpython\build\test_python_worker_21244æ                        
== CPU count: 16                                                                                       
== encodings: locale=cp1251 FS=utf-8                                                                   
== resources: all test resources are disabled, use -u option to unskip tests                           
                                                                                                       
Using random seed: 4064093575                                                                          
0:00:00 Run 1 test sequentially                                                                        
0:00:00 [1/1] test_winconsoleio                                                                        
test_abc (test.test_winconsoleio.WindowsConsoleIOTests.test_abc) ... ok                                
test_conin_conout_names (test.test_winconsoleio.WindowsConsoleIOTests.test_conin_conout_names) ... ok  
test_conout_path (test.test_winconsoleio.WindowsConsoleIOTests.test_conout_path) ... ok                
test_ctrl_z (test.test_winconsoleio.WindowsConsoleIOTests.test_ctrl_z) ... Ä^Z
ok
test_input (test.test_winconsoleio.WindowsConsoleIOTests.test_input) ... abc123
ϼўТλФЙ
A͏B ﬖ̳AA̝
ok
test_input_nonbmp (test.test_winconsoleio.WindowsConsoleIOTests.test_input_nonbmp) ... skipped 'Handling Non-BMP characters is bro
ken'
test_open_fd (test.test_winconsoleio.WindowsConsoleIOTests.test_open_fd) ... ok
test_open_name (test.test_winconsoleio.WindowsConsoleIOTests.test_open_name) ... ok
test_partial_reads (test.test_winconsoleio.WindowsConsoleIOTests.test_partial_reads) ... ϼўТλФЙ
ϼўТλФЙ
ϼўТλФЙ
ϼўТλФЙ
ϼўТλФЙ
ϼўТλФЙ
ϼўТλФЙ
ϼўТλФЙ
ϼўТλФЙ
ϼўТλФЙ
ϼўТλФЙ
ϼўТλФЙ
ϼўТλФЙ
ϼўТλФЙ
ϼўТλФЙ
ok
test_partial_surrogate_reads (test.test_winconsoleio.WindowsConsoleIOTests.test_partial_surrogate_reads) ... skipped 'Handling Non
-BMP characters is broken'
test_subclass_repr (test.test_winconsoleio.WindowsConsoleIOTests.test_subclass_repr) ... ok
test_write_empty_data (test.test_winconsoleio.WindowsConsoleIOTests.test_write_empty_data) ... ok

----------------------------------------------------------------------
Ran 10 tests in 0.036s

OK (skipped=2)

== Tests result: SUCCESS ==

1 test OK.

Total duration: 207 ms
Total tests: run=10 skipped=2
Total test files: run=1/1
Result: SUCCESS

CPython versions tested on:

CPython main branch

Operating systems tested on:

Windows

Linked PRs

@Eclips4 Eclips4 added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir OS-windows 3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes labels Jan 25, 2024
@zooba
Copy link
Member

zooba commented Jan 25, 2024

Unfortunately, it's not printing it, it's testing the console. The only way to suppress it is to skip the test.

If someone wants to add a console resource, go ahead (and make sure it's enabled in CI and buildbots). But there's no other "fix" for this - we need to test the console.

@zooba zooba removed the type-bug An unexpected behavior, bug, or error label Jan 25, 2024
Eclips4 added a commit to Eclips4/cpython that referenced this issue Jan 25, 2024
zooba pushed a commit that referenced this issue Jan 25, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 25, 2024
…es_resource('console')` decorator (pythonGH-114565)

(cherry picked from commit 33ae989)

Co-authored-by: Kirill Podoprigora <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 25, 2024
…es_resource('console')` decorator (pythonGH-114565)

(cherry picked from commit 33ae989)

Co-authored-by: Kirill Podoprigora <[email protected]>
zooba pushed a commit that referenced this issue Jan 25, 2024
…rce('console')` decorator (GH-114565)

(cherry picked from commit 33ae989)

Co-authored-by: Kirill Podoprigora <[email protected]>
zooba pushed a commit that referenced this issue Jan 25, 2024
…rce('console')` decorator (GH-114565)

(cherry picked from commit 33ae989)

Co-authored-by: Kirill Podoprigora <[email protected]>
@Eclips4 Eclips4 closed this as completed Jan 25, 2024
@Eclips4
Copy link
Member Author

Eclips4 commented Jan 25, 2024

Thanks Steve!

aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes OS-windows tests Tests in the Lib/test dir
Projects
None yet
Development

No branches or pull requests

2 participants