-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
test_tools.test_freeze broken on Mac framework build–probably should be skipped #113384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That's my bad, I added the error message but forgot to update the test. |
ronaldoussoren
added a commit
to ronaldoussoren/cpython
that referenced
this issue
Dec 22, 2023
ronaldoussoren
added a commit
that referenced
this issue
Dec 22, 2023
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Dec 22, 2023
…onGH-113390) (cherry picked from commit bee627c) Co-authored-by: Ronald Oussoren <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Dec 22, 2023
…onGH-113390) (cherry picked from commit bee627c) Co-authored-by: Ronald Oussoren <[email protected]>
This was referenced Dec 22, 2023
ronaldoussoren
added a commit
that referenced
this issue
Dec 22, 2023
ronaldoussoren
added a commit
that referenced
this issue
Dec 22, 2023
ryan-duve
pushed a commit
to ryan-duve/cpython
that referenced
this issue
Dec 26, 2023
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this issue
Jan 22, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this issue
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Bug report
Bug description:
I've been messing around with the Mac framework build and encountered a failing
test_tools.test_freeze
. It runsTools/freeze/freeze.py
which has this buried in it:That seems like the wrong way to skip the test, but I suppose it's useful if run from the command line. Based on a comment @ned-deily made in another issue, that might be better expressed as:
That said,
test_tools/test_freeze.py
should perhaps skip the test on Darwin framework builds with something like this:CPython versions tested on:
CPython main branch
Operating systems tested on:
macOS
Linked PRs
The text was updated successfully, but these errors were encountered: