Skip to content

test_pty: test_openpty() failed on aarch64 RHEL8 LTO + PGO 3.x #109960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vstinner opened this issue Sep 27, 2023 · 0 comments
Closed

test_pty: test_openpty() failed on aarch64 RHEL8 LTO + PGO 3.x #109960

vstinner opened this issue Sep 27, 2023 · 0 comments

Comments

@vstinner
Copy link
Member

vstinner commented Sep 27, 2023 •
edited by bedevere-app bot
Loading

aarch64 RHEL8 LTO + PGO 3.x:

0:00:16 load avg: 8.60 [299/463/1] test_pty failed (1 failure)
hi there
test_fork (test.test_pty.PtyTest.test_fork) ... ok
test_master_read (test.test_pty.PtyTest.test_master_read) ... ok
test_openpty (test.test_pty.PtyTest.test_openpty) ... FAIL

Stdout:
tty.tcgetattr(pty.STDIN_FILENO) failed
Calling pty.openpty()
Got master_fd=3, slave_fd=4, slave_name=None
Writing to slave_fd
Writing chunked output
test_spawn_doesnt_hang (test.test_pty.PtyTest.test_spawn_doesnt_hang) ... ok
test__copy_to_each (test.test_pty.SmallPtyTests.test__copy_to_each)
Test the normal data case on both master_fd and stdin. ... ok
test__restore_tty_mode_normal_return (test.test_pty.SmallPtyTests.test__restore_tty_mode_normal_return)
Test that spawn resets the tty mode no when _copy returns normally. ... ok

======================================================================
FAIL: test_openpty (test.test_pty.PtyTest.test_openpty)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_pty.py", line 192, in test_openpty
    s2 = _readline(master_fd)
         ^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_pty.py", line 68, in _readline
    return reader.readline()
           ^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_pty.py", line 105, in handle_sig
    self.fail("isatty hung")
AssertionError: isatty hung

Stdout:
tty.tcgetattr(pty.STDIN_FILENO) failed
Calling pty.openpty()
Got master_fd=3, slave_fd=4, slave_name=None
Writing to slave_fd
Writing chunked output

----------------------------------------------------------------------
Ran 6 tests in 10.023s

FAILED (failures=1)
test test_pty failed

build: https://buildbot.python.org/all/#/builders/78/builds/5451

Linked PRs
vstinner added a commit to vstinner/cpython that referenced this issue Sep 28, 2023
@vstinner
pythongh-109960: Remove test_pty timeout of 10 seconds
0ffcfa5 
In 2003, test_pty got a hardcoded timeout to 10 seconds to prevent
hanging on AIX & HPUX "if run after test_openpty":
commit 7d81452. Since 2003, test_pty
was no longer reported to hang on AIX. But today, the test can fail
simply because a CI is very busy running other tests in parallel.
The timeout of 10 seconds is no longer needed, just remove it.
vstinner added a commit to vstinner/cpython that referenced this issue Sep 28, 2023
@vstinner
pythongh-109960: Remove test_pty timeout of 10 seconds
6fdfbf0 
In 2003, test_pty got a hardcoded timeout of 10 seconds to prevent
hanging on AIX & HPUX "if run after test_openpty":
commit 7d81452. Since 2003, test_pty
was no longer reported to hang on AIX. But today, the test can fail
simply because a CI is very busy running other tests in parallel.
The timeout of 10 seconds is no longer needed, just remove it.
vstinner added a commit to vstinner/cpython that referenced this issue Sep 28, 2023
@vstinner
pythongh-109960: Remove test_pty timeout of 10 seconds
7140d48 
In 2003, test_pty got a hardcoded timeout of 10 seconds to prevent
hanging on AIX & HPUX "if run after test_openpty":
commit 7d81452. Since 2003, test_pty
was no longer reported to hang on AIX. But today, the test can fail
simply because a CI is very busy running other tests in parallel.
The timeout of 10 seconds is no longer needed, just remove it.
Moreover, regrtest now has multiple built-in generic timeout
mecanisms.
@bedevere-app bedevere-app bot mentioned this issue Sep 28, 2023
Merged
vstinner added a commit that referenced this issue Sep 29, 2023
@vstinner
gh-109960: Remove test_pty timeout of 10 seconds (#110058)
5fdcea7 
In 2003, test_pty got a hardcoded timeout of 10 seconds to prevent
hanging on AIX & HPUX "if run after test_openpty":
commit 7d81452. Since 2003, test_pty
was no longer reported to hang on AIX. But today, the test can fail
simply because a CI is busy running other tests in parallel.
The timeout of 10 seconds is no longer needed, just remove it.
Moreover, regrtest now has multiple built-in generic timeout
mecanisms.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 29, 2023
@vstinner @miss-islington
pythongh-109960: Remove test_pty timeout of 10 seconds (pythonGH-110058)
882434d 
In 2003, test_pty got a hardcoded timeout of 10 seconds to prevent
hanging on AIX & HPUX "if run after test_openpty":
commit 7d81452. Since 2003, test_pty
was no longer reported to hang on AIX. But today, the test can fail
simply because a CI is busy running other tests in parallel.
The timeout of 10 seconds is no longer needed, just remove it.
Moreover, regrtest now has multiple built-in generic timeout
mecanisms.
(cherry picked from commit 5fdcea7)

Co-authored-by: Victor Stinner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 29, 2023
@vstinner @miss-islington
pythongh-109960: Remove test_pty timeout of 10 seconds (pythonGH-110058)
fd16e71 
In 2003, test_pty got a hardcoded timeout of 10 seconds to prevent
hanging on AIX & HPUX "if run after test_openpty":
commit 7d81452. Since 2003, test_pty
was no longer reported to hang on AIX. But today, the test can fail
simply because a CI is busy running other tests in parallel.
The timeout of 10 seconds is no longer needed, just remove it.
Moreover, regrtest now has multiple built-in generic timeout
mecanisms.
(cherry picked from commit 5fdcea7)

Co-authored-by: Victor Stinner <[email protected]>
This was referenced Sep 29, 2023
Merged
Merged
csm10495 pushed a commit to csm10495/cpython that referenced this issue Sep 29, 2023
@vstinner @csm10495
pythongh-109960: Remove test_pty timeout of 10 seconds (python#110058)
25dc42c 
In 2003, test_pty got a hardcoded timeout of 10 seconds to prevent
hanging on AIX & HPUX "if run after test_openpty":
commit 7d81452. Since 2003, test_pty
was no longer reported to hang on AIX. But today, the test can fail
simply because a CI is busy running other tests in parallel.
The timeout of 10 seconds is no longer needed, just remove it.
Moreover, regrtest now has multiple built-in generic timeout
mecanisms.
vstinner added a commit that referenced this issue Sep 29, 2023
@miss-islington @vstinner
[3.11] gh-109960: Remove test_pty timeout of 10 seconds (GH-110058) (#…
a997295 
…110061)

gh-109960: Remove test_pty timeout of 10 seconds (GH-110058)

In 2003, test_pty got a hardcoded timeout of 10 seconds to prevent
hanging on AIX & HPUX "if run after test_openpty":
commit 7d81452. Since 2003, test_pty
was no longer reported to hang on AIX. But today, the test can fail
simply because a CI is busy running other tests in parallel.
The timeout of 10 seconds is no longer needed, just remove it.
Moreover, regrtest now has multiple built-in generic timeout
mecanisms.
(cherry picked from commit 5fdcea7)

Co-authored-by: Victor Stinner <[email protected]>
Yhg1s pushed a commit that referenced this issue Oct 2, 2023
@miss-islington @vstinner
[3.12] gh-109960: Remove test_pty timeout of 10 seconds (GH-110058) (#…
aaa8bf1 
…110060)

gh-109960: Remove test_pty timeout of 10 seconds (GH-110058)

In 2003, test_pty got a hardcoded timeout of 10 seconds to prevent
hanging on AIX & HPUX "if run after test_openpty":
commit 7d81452. Since 2003, test_pty
was no longer reported to hang on AIX. But today, the test can fail
simply because a CI is busy running other tests in parallel.
The timeout of 10 seconds is no longer needed, just remove it.
Moreover, regrtest now has multiple built-in generic timeout
mecanisms.
(cherry picked from commit 5fdcea7)

Co-authored-by: Victor Stinner <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@vstinner @Glyphack
pythongh-109960: Remove test_pty timeout of 10 seconds (python#110058)
b873e22 
In 2003, test_pty got a hardcoded timeout of 10 seconds to prevent
hanging on AIX & HPUX "if run after test_openpty":
commit 7d81452. Since 2003, test_pty
was no longer reported to hang on AIX. But today, the test can fail
simply because a CI is busy running other tests in parallel.
The timeout of 10 seconds is no longer needed, just remove it.
Moreover, regrtest now has multiple built-in generic timeout
mecanisms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vstinner