Skip to content

incorrect SyntaxError #109120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mqyhlkahu opened this issue Sep 8, 2023 · 3 comments · Fixed by #117444
Closed

incorrect SyntaxError #109120

mqyhlkahu opened this issue Sep 8, 2023 · 3 comments · Fixed by #117444
Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-parser type-bug An unexpected behavior, bug, or error

Comments

@mqyhlkahu
Copy link

mqyhlkahu commented Sep 8, 2023 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

The following input will cause a SyntaxError. That's all well and good, but the message for the SyntaxError is incorrect.

f(A,*)
SyntaxError: iterable argument unpacking follows keyword argument unpacking

This is not correct. That error message is intended for cases like this f(**kwargs, *args).
This bug is present on 3.9, 3.10, and 3.11. I haven't tested 3.12, but I suspect that it is present there as well. The bug is not present on 3.8.

CPython versions tested on:

3.8 3.9, 3.10, 3.11

Operating systems tested on:

Linux, Windows

Linked PRs
@mqyhlkahu mqyhlkahu added the type-bug An unexpected behavior, bug, or error label Sep 8, 2023
@ambv
Copy link
Contributor

ambv commented Sep 8, 2023

Yeah, no changes in 3.12 and main for the error message.

@sobolevn
Copy link
Member

sobolevn commented Sep 8, 2023

On 3.8 it used to be just:

  File "main.py", line 2

    f(A,*)

         ^

SyntaxError: invalid syntax

@AlexWaygood AlexWaygood added 3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes labels Sep 8, 2023
@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Nov 25, 2023
grigoriev-semyon added a commit to grigoriev-semyon/cpython that referenced this issue Apr 2, 2024
@grigoriev-semyon
pythongh-109120: Fix handle of incorrect star expressions
92add41
@grigoriev-semyon grigoriev-semyon mentioned this issue Apr 2, 2024
Merged
pablogsal pushed a commit that referenced this issue Apr 2, 2024
@grigoriev-semyon
gh-109120: Fix syntax error in handlinh of incorrect star expressions (…
c97d3af 
…#117444)
grigoriev-semyon added a commit to grigoriev-semyon/cpython that referenced this issue Apr 2, 2024
@grigoriev-semyon
pythongh-109120: Fix syntax error in handlinh of incorrect star expre…
53adcd8 
…ssions (python#117444)

(cherry picked from commit c97d3af)
grigoriev-semyon added a commit to grigoriev-semyon/cpython that referenced this issue Apr 2, 2024
@grigoriev-semyon
pythongh-109120: Fix syntax error in handlinh of incorrect star expre…
ebdd29f 
…ssions (python#117444)

(cherry picked from commit c97d3af)
@bedevere-app bedevere-app bot mentioned this issue Apr 2, 2024
Merged
@grigoriev-semyon grigoriev-semyon mentioned this issue Apr 2, 2024
Closed
grigoriev-semyon added a commit to grigoriev-semyon/cpython that referenced this issue Apr 2, 2024
@grigoriev-semyon
pythongh-109120: Fix syntax error in handlinh of incorrect star expre…
87202f0 
…ssions (python#117444)

(cherry picked from commit c97d3af)
@bedevere-app bedevere-app bot mentioned this issue Apr 2, 2024
Merged
@terryjreedy
Copy link
Member

Should the backports be merged?

pablogsal pushed a commit that referenced this issue Apr 3, 2024
@grigoriev-semyon
[3.11] gh-109120: Fix syntax error in handlinh of incorrect star expr…
3bc0d2b 
…essions… (#117464)

gh-109120: Fix syntax error in handlinh of incorrect star expressions (#117444)

(cherry picked from commit c97d3af)
terryjreedy pushed a commit that referenced this issue Apr 4, 2024
@grigoriev-semyon
[3.12] gh-109120: Fix syntax error in handlinh of incorrect star expr…
a49426a 
…essions… (#117465)

gh-109120: Fix syntax error in handlinh of incorrect star expressions (#117444)

(cherry picked from commit c97d3af)
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@grigoriev-semyon @diegorusso
pythongh-109120: Fix syntax error in handlinh of incorrect star expre…
a08eb34 
…ssions (python#117444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-parser type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-109120: Fix handle of incorrect star expressions grigoriev-semyon/cpython
7 participants
@ambv @JelleZijlstra @iritkatriel @sobolevn @terryjreedy @AlexWaygood @mqyhlkahu