Skip to content

PEP 695: not all name collisions are tested #105437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sobolevn opened this issue Jun 7, 2023 · 0 comments
Closed

PEP 695: not all name collisions are tested #105437

sobolevn opened this issue Jun 7, 2023 · 0 comments
Assignees
Labels
tests Tests in the Lib/test dir topic-typing type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Jun 7, 2023

Right now there are two tests for name colisions of type parameters of type aliases and functions:

They only test A and **A collide. But, PEP clearly states that A and *A collide as well.
I will send a PR.

I am really sorry that I have to put all my review comments to #103764 as separate issues, but I've missed my chance to properly review the PEP's implementation.

Linked PRs

@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir topic-typing labels Jun 7, 2023
@sobolevn sobolevn self-assigned this Jun 7, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Jun 7, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Jun 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 7, 2023
JelleZijlstra pushed a commit that referenced this issue Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir topic-typing type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants