Skip to content

Use named constants for MAKE_FUNCTION oparg #105214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JelleZijlstra opened this issue Jun 2, 2023 · 0 comments
Closed

Use named constants for MAKE_FUNCTION oparg #105214

JelleZijlstra opened this issue Jun 2, 2023 · 0 comments
Assignees
@JelleZijlstra
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Jun 2, 2023 •
edited by bedevere-bot
Loading

The oparg for MAKE_FUNCTION is a mask of various flags (e.g. 0x8 means it has a closure). These are currently hardcoded as integers; let's use named constants instead.

Linked PRs
@JelleZijlstra JelleZijlstra added type-feature A feature request or enhancement interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jun 2, 2023
@JelleZijlstra JelleZijlstra self-assigned this Jun 2, 2023
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this issue Jun 2, 2023
@JelleZijlstra
pythongh-105214: Use named constants for MAKE_FUNCTION oparg
591327e
@bedevere-bot bedevere-bot mentioned this issue Jun 2, 2023
Merged
JelleZijlstra added a commit that referenced this issue Jun 2, 2023
@JelleZijlstra
gh-105214: Use named constants for MAKE_FUNCTION oparg (#105215)
44bb03f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JelleZijlstra JelleZijlstra

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JelleZijlstra