-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Add missing tests to the dis module #103804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jkchandalia can you discuss your motivation for |
@nanjekyejoannah I had a look at Line 608 in b934f97
Because |
disco is documented: https://docs.python.org/3/library/dis.html#dis.disco Perhaps it should also be deprecated, I don't know the history. |
@iritkatriel @nanjekyejoannah it looks like dis.disco was introduced in the initial python commit in 1990 by Guido: 217a5fa I'm assuming it's been kept around for backwards compatibility and may not yet be a good idea to deprecate but I defer to your judgement. I've opened a PR with a test for |
Improve test coverage for the dis module i.e
cpython/lib/dis.py
, tests are incpython/Lib/tests/test_dis.py
. Missing tests include:dis.disco
dis.findlinestarts
Linked PRs
The text was updated successfully, but these errors were encountered: