Closed
Description
Here's how it is defined right now:
Lines 640 to 655 in 837ba05
I see two major problems here:
cPickle
does not exist anymore (since 3.0), so it always fails withImportError
. If we want to be sure that both Python and C versions behave the same - we can surely do that withimport_helper.import_fresh_module
or we can drop this part and only keeppickle
module direct usage (as other modules do). I prefer the second option, because of how other things are tested. But, in the end it is up to maintainers to decide :)- Not all
pickle
protocols are tested: we need to usepickle.HIGHEST_PROTOCOL
instead of just three items
PR is incoming!