Skip to content

Commit f574ce7

Browse files
miss-islingtonlysnikolaou
authored andcommitted
bpo-21263: Skip test_gdb when python has been compiled with LLVM clang (GH-10318) (GH-10326)
(cherry picked from commit 59668aa) Co-authored-by: Lysandros Nikolaou <[email protected]>
1 parent 4614b98 commit f574ce7

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

Lib/test/test_gdb.py

+5
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import locale
77
import os
8+
import platform
89
import re
910
import subprocess
1011
import sys
@@ -54,6 +55,10 @@ def get_gdb_version():
5455
if not sysconfig.is_python_build():
5556
raise unittest.SkipTest("test_gdb only works on source builds at the moment.")
5657

58+
if 'Clang' in platform.python_compiler() and sys.platform == 'darwin':
59+
raise unittest.SkipTest("test_gdb doesn't work correctly when python is"
60+
" built with LLVM clang")
61+
5762
# Location of custom hooks file in a repository checkout.
5863
checkout_hook_path = os.path.join(os.path.dirname(sys.executable),
5964
'python-gdb.py')

Misc/ACKS

+1
Original file line numberDiff line numberDiff line change
@@ -1107,6 +1107,7 @@ Samuel Nicolary
11071107
Jonathan Niehof
11081108
Gustavo Niemeyer
11091109
Oscar Nierstrasz
1110+
Lysandros Nikolaou
11101111
Hrvoje Nikšić
11111112
Gregory Nofi
11121113
Jesse Noller
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
After several reports that test_gdb does not work properly on macOS and
2+
since gdb is not shipped by default anymore, test_gdb is now skipped on
3+
macOS when LLVM Clang has been used to compile Python. Patch by
4+
Lysandros Nikolaou

0 commit comments

Comments
 (0)