Skip to content

Commit ca6db4f

Browse files
[3.14] gh-127146: Emscripten: more regular stack overflow skips (GH-136708) (#136712)
Makes the Emscripten stack overflow skip message consistent with WASI, and replaces some ad-hoc skips. (cherry picked from commit c730952) Co-authored-by: Hood Chatham <[email protected]>
1 parent 9ab29ca commit ca6db4f

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Lib/test/support/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,7 @@ def skip_android_selinux(name):
570570
is_wasi = sys.platform == "wasi"
571571

572572
def skip_emscripten_stack_overflow():
573-
return unittest.skipIf(is_emscripten, "Exhausts limited stack on Emscripten")
573+
return unittest.skipIf(is_emscripten, "Exhausts stack on Emscripten")
574574

575575
def skip_wasi_stack_overflow():
576576
return unittest.skipIf(is_wasi, "Exhausts stack on WASI")

Lib/test/test_descr.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3942,7 +3942,7 @@ def __del__(self):
39423942
# it as a leak.
39433943
del C.__del__
39443944

3945-
@unittest.skipIf(support.is_emscripten, "Seems to works in Pyodide?")
3945+
@support.skip_emscripten_stack_overflow()
39463946
@support.skip_wasi_stack_overflow()
39473947
def test_slots_trash(self):
39483948
# Testing slot trash...

Lib/test/test_xml_etree_c.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def test_del_attribute(self):
5858
self.assertEqual(element.attrib, {'A': 'B', 'C': 'D'})
5959

6060
@support.skip_wasi_stack_overflow()
61-
@unittest.skipIf(support.is_emscripten, "segfaults")
61+
@support.skip_emscripten_stack_overflow()
6262
def test_trashcan(self):
6363
# If this test fails, it will most likely die via segfault.
6464
e = root = cET.Element('root')

0 commit comments

Comments
 (0)