[3.12] gh-122311: Fix a refleak in pickle (GH-122411) (GH-122416)

miss-islington · serhiy-storchaka · web-flow · commit bad84975ffda · 2024-07-29T19:10:46.000Z
(cherry picked from commit 68840e9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
diff --git a/Modules/_pickle.c b/Modules/_pickle.c
@@ -3188,6 +3188,7 @@ batch_dict(PickleState *state, PicklerObject *self, PyObject *iter)
             if (!PyTuple_Check(obj) || PyTuple_Size(obj) != 2) {
                 PyErr_SetString(PyExc_TypeError, "dict items "
                                 "iterator must return 2-tuples");
+                Py_DECREF(obj);
                 return -1;
             }
             i = save(state, self, PyTuple_GET_ITEM(obj, 0), 0);

Original file line number	Diff line number	Diff line change
`@@ -3188,6 +3188,7 @@ batch_dict(PickleState state, PicklerObject self, PyObject *iter)`
`3188`	`3188`	`if (!PyTuple_Check(obj) \|\| PyTuple_Size(obj) != 2) {`
`3189`	`3189`	`PyErr_SetString(PyExc_TypeError, "dict items "`
`3190`	`3190`	`"iterator must return 2-tuples");`
	`3191`	`+ Py_DECREF(obj);`
`3191`	`3192`	`return -1;`
`3192`	`3193`	`}`
`3193`	`3194`	`i = save(state, self, PyTuple_GET_ITEM(obj, 0), 0);`