Skip to content

Commit ac2c957

Browse files
colesburycorona10
authored andcommitted
Add TODOs for missing Py_DECREF specializations
These aren't necessary for correctness, just performance.
1 parent c6c6ec6 commit ac2c957

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

Include/internal/pycore_object.h

+1
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ _Py_DECREF_NO_DEALLOC(PyObject *op)
210210
}
211211

212212
#else
213+
// TODO: implement Py_DECREF specializations for Py_NOGIL build
213214
static inline void
214215
_Py_DECREF_SPECIALIZED(PyObject *op, const destructor destruct)
215216
{

Python/ceval.c

+1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
// the limit of PGO, and that limit cannot be configured.
5353
// Define them as macros to make sure that they are always inlined by the
5454
// preprocessor.
55+
// TODO: implement Py_DECREF macro for Py_NOGIL
5556

5657
#undef Py_DECREF
5758
#define Py_DECREF(arg) \

0 commit comments

Comments
 (0)