Skip to content

Commit a02979f

Browse files
gh-98512: Add more tests for ValuesView (GH-98515)
(cherry picked from commit 29e027c) Co-authored-by: Nikita Sobolev <[email protected]>
1 parent 2199a7d commit a02979f

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

Lib/test/test_collections.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1594,6 +1594,7 @@ def __len__(self):
15941594
containers = [
15951595
seq,
15961596
ItemsView({1: nan, 2: obj}),
1597+
KeysView({1: nan, 2: obj}),
15971598
ValuesView({1: nan, 2: obj})
15981599
]
15991600
for container in containers:
@@ -1857,6 +1858,8 @@ def test_MutableMapping_subclass(self):
18571858
mymap['red'] = 5
18581859
self.assertIsInstance(mymap.keys(), Set)
18591860
self.assertIsInstance(mymap.keys(), KeysView)
1861+
self.assertIsInstance(mymap.values(), Collection)
1862+
self.assertIsInstance(mymap.values(), ValuesView)
18601863
self.assertIsInstance(mymap.items(), Set)
18611864
self.assertIsInstance(mymap.items(), ItemsView)
18621865

Lib/test/test_dictviews.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,9 @@ def test_abc_registry(self):
320320
self.assertIsInstance(d.values(), collections.abc.ValuesView)
321321
self.assertIsInstance(d.values(), collections.abc.MappingView)
322322
self.assertIsInstance(d.values(), collections.abc.Sized)
323+
self.assertIsInstance(d.values(), collections.abc.Collection)
324+
self.assertIsInstance(d.values(), collections.abc.Iterable)
325+
self.assertIsInstance(d.values(), collections.abc.Container)
323326

324327
self.assertIsInstance(d.items(), collections.abc.ItemsView)
325328
self.assertIsInstance(d.items(), collections.abc.MappingView)

0 commit comments

Comments
 (0)