Skip to content

Commit 9c4147d

Browse files
committed
apply review
1 parent 4bc265a commit 9c4147d

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

Lib/test/test_inspect/test_inspect.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,8 @@
3030

3131
try:
3232
import _pickle
33-
MISSING_C_PICKLE = False
3433
except ImportError:
35-
MISSING_C_PICKLE = True
34+
_pickle = None
3635

3736

3837
try:
@@ -1415,7 +1414,7 @@ def test(): pass
14151414

14161415
@unittest.skipIf(MISSING_C_DOCSTRINGS,
14171416
"Signature information for builtins requires docstrings")
1418-
@unittest.skipIf(MISSING_C_PICKLE, "requires _pickle")
1417+
@unittest.skipUnless(_pickle, "requires _pickle module")
14191418
def test_getfullargspec_builtin_methods(self):
14201419
self.assertFullArgSpecEquals(_pickle.Pickler.dump, ['self', 'obj'])
14211420

@@ -4641,7 +4640,7 @@ class D(C): pass
46414640

46424641
@unittest.skipIf(MISSING_C_DOCSTRINGS,
46434642
"Signature information for builtins requires docstrings")
4644-
@unittest.skipIf(MISSING_C_PICKLE, "requires _pickle")
4643+
@unittest.skipUnless(_pickle, "requires _pickle module")
46454644
def test_signature_on_builtin_class(self):
46464645
expected = ('(file, protocol=None, fix_imports=True, '
46474646
'buffer_callback=None)')
@@ -5183,7 +5182,7 @@ class foo: pass
51835182

51845183
@unittest.skipIf(MISSING_C_DOCSTRINGS,
51855184
"Signature information for builtins requires docstrings")
5186-
@unittest.skipIf(MISSING_C_PICKLE, "requires _pickle")
5185+
@unittest.skipUnless(_pickle, "requires _pickle module")
51875186
def test_signature_from_callable_builtin_obj(self):
51885187
class MySignature(inspect.Signature): pass
51895188
sig = MySignature.from_callable(_pickle.Pickler)

0 commit comments

Comments
 (0)