Skip to content

Commit 966f0f4

Browse files
author
Erlend E. Aasland
committed
Address review: include _destructor
1 parent 5b9238c commit 966f0f4

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Modules/_sqlite/connection.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -800,7 +800,7 @@ free_callback_context(callback_context *ctx)
800800
}
801801

802802
static void
803-
_destructor(void *ctx)
803+
destructor_callback(void *ctx)
804804
{
805805
if (ctx != NULL) {
806806
// This function may be called without the GIL held, so we need to
@@ -858,7 +858,7 @@ pysqlite_connection_create_function_impl(pysqlite_Connection *self,
858858
_pysqlite_func_callback,
859859
NULL,
860860
NULL,
861-
&_destructor); // will decref func
861+
&destructor_callback); // will decref func
862862

863863
if (rc != SQLITE_OK) {
864864
/* Workaround for SQLite bug: no error code or string is available here */
@@ -899,7 +899,7 @@ pysqlite_connection_create_aggregate_impl(pysqlite_Connection *self,
899899
0,
900900
&_pysqlite_step_callback,
901901
&_pysqlite_final_callback,
902-
&_destructor); // will decref func
902+
&destructor_callback); // will decref func
903903
if (rc != SQLITE_OK) {
904904
/* Workaround for SQLite bug: no error code or string is available here */
905905
PyErr_SetString(self->OperationalError, "Error creating aggregate");
@@ -1727,7 +1727,7 @@ pysqlite_connection_create_collation_impl(pysqlite_Connection *self,
17271727
}
17281728
rc = sqlite3_create_collation_v2(self->db, name, flags, ctx,
17291729
&pysqlite_collation_callback,
1730-
&_destructor);
1730+
&destructor_callback);
17311731
}
17321732

17331733
if (rc != SQLITE_OK) {

0 commit comments

Comments
 (0)