[3.13] gh-109700: fix memory error handling in PyDict_SetDefault (#136338) (#136642)

kumaraditya303 · web-flow · commit 823bf76d376f · 2025-07-14T08:25:31.000Z
gh-109700: fix memory error handling in `PyDict_SetDefault` (#136338) (cherry picked from commit d22e073)
diff --git a/Misc/NEWS.d/next/Core and Builtins/2025-07-06-14-53-19.gh-issue-109700.KVNQQi.rst b/Misc/NEWS.d/next/Core and Builtins/2025-07-06-14-53-19.gh-issue-109700.KVNQQi.rst
@@ -0,0 +1 @@
+Fix memory error handling in :c:func:`PyDict_SetDefault`.
diff --git a/Objects/dictobject.c b/Objects/dictobject.c
@@ -4340,6 +4340,7 @@ dict_setdefault_ref_lock_held(PyObject *d, PyObject *key, PyObject *default_valu
             if (result) {
                 *result = NULL;
             }
+            return -1;
         }
 
         MAINTAIN_TRACKING(mp, key, value);

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix memory error handling in :c:func:`PyDict_SetDefault`.
Original file line number	Diff line number	Diff line change
`@@ -4340,6 +4340,7 @@ dict_setdefault_ref_lock_held(PyObject d, PyObject key, PyObject *default_valu`
`4340`	`4340`	`if (result) {`
`4341`	`4341`	`*result = NULL;`
`4342`	`4342`	`}`
	`4343`	`+ return -1;`
`4343`	`4344`	`}`
`4344`	`4345`
`4345`	`4346`	`MAINTAIN_TRACKING(mp, key, value);`