Skip to content

Commit 769ddb0

Browse files
miss-islingtonvstinner
authored andcommitted
[3.6] bpo-31448, test_poplib: Fix ResourceWarning (GH-3542) (#3543)
Call POP3.close(), don't close close directly the sock attribute. (cherry picked from commit d165e14)
1 parent 6c25b73 commit 769ddb0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Lib/test/test_poplib.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,7 @@ def testTimeoutDefault(self):
483483
finally:
484484
socket.setdefaulttimeout(None)
485485
self.assertEqual(pop.sock.gettimeout(), 30)
486-
pop.sock.close()
486+
pop.close()
487487

488488
def testTimeoutNone(self):
489489
self.assertIsNone(socket.getdefaulttimeout())
@@ -493,12 +493,12 @@ def testTimeoutNone(self):
493493
finally:
494494
socket.setdefaulttimeout(None)
495495
self.assertIsNone(pop.sock.gettimeout())
496-
pop.sock.close()
496+
pop.close()
497497

498498
def testTimeoutValue(self):
499499
pop = poplib.POP3(HOST, self.port, timeout=30)
500500
self.assertEqual(pop.sock.gettimeout(), 30)
501-
pop.sock.close()
501+
pop.close()
502502

503503

504504
def test_main():

0 commit comments

Comments
 (0)