Skip to content

Commit d165e14

Browse files
authored
bpo-31448, test_poplib: Fix ResourceWarning (#3542)
Call POP3.close(), don't close close directly the sock attribute.
1 parent a7b3bc5 commit d165e14

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Lib/test/test_poplib.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ def testTimeoutDefault(self):
488488
finally:
489489
socket.setdefaulttimeout(None)
490490
self.assertEqual(pop.sock.gettimeout(), 30)
491-
pop.sock.close()
491+
pop.close()
492492

493493
def testTimeoutNone(self):
494494
self.assertIsNone(socket.getdefaulttimeout())
@@ -498,12 +498,12 @@ def testTimeoutNone(self):
498498
finally:
499499
socket.setdefaulttimeout(None)
500500
self.assertIsNone(pop.sock.gettimeout())
501-
pop.sock.close()
501+
pop.close()
502502

503503
def testTimeoutValue(self):
504504
pop = poplib.POP3(HOST, self.port, timeout=30)
505505
self.assertEqual(pop.sock.gettimeout(), 30)
506-
pop.sock.close()
506+
pop.close()
507507

508508

509509
def test_main():

0 commit comments

Comments
 (0)