Skip to content

Commit 18a9024

Browse files
authored
bpo-32604: Fix reference leak in select module (GH-20600)
Fix reference leak in PyInit_select() of the select module: remove Py_INCREF(poll_Type).
1 parent 317bab0 commit 18a9024

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Fix reference leak in the :mod:`select` module when the the module is
2+
imported in a subinterpreter.

Modules/selectmodule.c

-2
Original file line numberDiff line numberDiff line change
@@ -2482,7 +2482,6 @@ PyInit_select(void)
24822482
if (poll_Type == NULL)
24832483
return NULL;
24842484
get_select_state(m)->poll_Type = (PyTypeObject *)poll_Type;
2485-
Py_INCREF(poll_Type);
24862485

24872486
PyModule_AddIntMacro(m, POLLIN);
24882487
PyModule_AddIntMacro(m, POLLPRI);
@@ -2518,7 +2517,6 @@ PyInit_select(void)
25182517
if (devpoll_Type == NULL)
25192518
return NULL;
25202519
get_select_state(m)->devpoll_Type = (PyTypeObject *)devpoll_Type;
2521-
Py_INCREF(devpoll_Type);
25222520
#endif
25232521

25242522
#ifdef HAVE_EPOLL

0 commit comments

Comments
 (0)