Skip to content

Loosen README check for CPython working directory #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cemeyer
Copy link

@cemeyer cemeyer commented Sep 20, 2018

Tauthon is a fork of CPython2.7 and has essentially the same organizational
and naming conventions that the prior code attempted to verify by evaluating
the 'Python version 2' regular expression against the first line of README.
Allow blurb to generate entries in the Tauthon fork by slightly relaxing
this regex.

Tauthon is a fork of CPython2.7 and has essentially the same organizational
and naming conventions that the prior code attempted to verify by evaluating
the 'Python version 2' regular expression against the first line of README.
Allow `blurb` to generate entries in the Tauthon fork by slightly relaxing
this regex.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@cemeyer
Copy link
Author

cemeyer commented Sep 20, 2018

This work is trivial. Consider it released into the public domain, or CC0 if you are European.

I don't have a bugs.python.org username and can't sign a CLA.

@terryjreedy
Copy link
Member

I agree that /Py/(Py|Tau)/ is trivial enough to not need a CLA. (In the future, a GitHub account will be sufficient to that.)

blurb was written by and it still maintained by Larry Hastings, who would have to approve any change, so my comments below are unofficial opinions.

If we wanted to accommodate CPython forks, we should not 'bless' Tauthon only. /Py/./ would potentially also accommodate things like 'Brython'. But it is not clear to me that we want to do this, as it would subvert part of the apparent purpose of the function that uses the RE.

If you were to start your Tauthon readme with "This is Python version 2.7 as modified and augmented by the Tauthon fork thereof.", no patch would be needed. Note that I intentionally did not put a comma after '7'. I believe our lawyer and trademark group would not object to this wording.

@cemeyer
Copy link
Author

cemeyer commented Sep 20, 2018

Maybe the RE is unnecessary? The checks for directory layout and interpreter files seem explicit enough to me to confirm we are Python (or at least, a fork).

Yeah, I agree it can be worked around on the Tauthon end by munging the Tauthon README to comply with the tool. I believe the README was changed (from "This is Python 2.8…") at the request of the Python trademark holder — Tauthon can't claim to be Python.

Your suggested README compromise seems fine to me, but I don't know that it would appeal to the Python trademark holder or their lawyer :-). And I am not a lawyer :-).

@arhadthedev
Copy link
Member

If we wanted to accommodate CPython forks, we should not 'bless' Tauthon only

I made an alternative PR (gh-473) that blesses all *thons in a *NIX fashion.

@arhadthedev
Copy link
Member

Superseded by gh-473.

@arhadthedev arhadthedev closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants