Skip to content

Add Python 3.7 to Travis CI #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2018
Merged

Add Python 3.7 to Travis CI #272

merged 1 commit into from
Aug 21, 2018

Conversation

webknjaz
Copy link
Contributor

@webknjaz webknjaz commented Jul 2, 2018

No description provided.

@Mariatta
Copy link
Member

Mariatta commented Jul 9, 2018

Should we test for both 3.7 and 3.7-dev?

@webknjaz
Copy link
Contributor Author

Depending on your preferences there's also 3.8-dev/nightly. Anything would work.

@webknjaz webknjaz force-pushed the feature/test-against-python-3.7 branch 2 times, most recently from 5bf7bbf to c71fc67 Compare August 6, 2018 12:03
@webknjaz webknjaz force-pushed the feature/test-against-python-3.7 branch from ff57ad2 to 305e0c4 Compare August 6, 2018 18:05
@webknjaz
Copy link
Contributor Author

webknjaz commented Aug 6, 2018

@Mariatta I've rebased this PR. Should be safe to merge now.

@webknjaz
Copy link
Contributor Author

@Mariatta ^^

@Mariatta Mariatta merged commit d969191 into python:master Aug 21, 2018
@Mariatta
Copy link
Member

Thanks!! 🌮

@webknjaz
Copy link
Contributor Author

@Mariatta could you please release a new version of cherry-picker? Some ppl have to work with a version from Git because of missing fixes.

@webknjaz
Copy link
Contributor Author

Hm.. something's wrong. This job shouldn't appear in build: https://travis-ci.org/python/core-workflow/jobs/418766372

@webknjaz
Copy link
Contributor Author

Oh..

if: false

So it didn't work. it probably needs something more falsy.

@Mariatta
Copy link
Member

@Mariatta could you please release a new version of cherry-picker? Some ppl have to work with a version from Git because of missing fixes.

Ok. I was wondering if I should wait for the fix of #277 first or not?

@Mariatta
Copy link
Member

hmm.. Maybe I should revert this first?

@webknjaz
Copy link
Contributor Author

No, it's probably because of duplicate key and travis' parser "saw" only first one or so. It's probably from previous PR, not this one

@webknjaz
Copy link
Contributor Author

And it's not critical, because there's another check preventing actual deploy. I'll fix if-clause anyway.

@webknjaz
Copy link
Contributor Author

I've raised the issue with Travis, because it looks like their bug: travis-ci/travis-conditions#13.

@webknjaz webknjaz mentioned this pull request Aug 21, 2018
Merged
@webknjaz
Copy link
Contributor Author

Fix/workaround/hack: #281
@Mariatta ^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webknjaz @Mariatta @the-knights-who-say-ni