Skip to content

Test blurb in Travis-CI #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 17, 2018
Merged

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Jun 26, 2017

No description provided.

@brettcannon
Copy link
Member

If #146 goes in then the .travis.yml could be turned into a matrix where blurb is tested with Python 3.5 and cherry_picker with 3.6 and an environment variable of TESTING to make it obvious which build is testing what tool.

@pitrou
Copy link
Member Author

pitrou commented Jun 26, 2017

Can't cherry_picker be tested be with 3.5 as well? Or doesn't it work there?

@Mariatta
Copy link
Member

cherry_picker doesn't work in Python 3.5.

@pitrou
Copy link
Member Author

pitrou commented Jun 27, 2017

This is pending fix of issue python/blurb#1 for blurb tests to actually run.

@larryhastings
Copy link
Contributor

Currently this has a conflict. I'd be happy to review it, but can you fix the conflicts first? Thanks.

@pitrou
Copy link
Member Author

pitrou commented Jul 15, 2017

Ok, conflicts fixed.

@larryhastings
Copy link
Contributor

There's now a merge conflict in .travis.yml. It looks like an easy merge based on a simple visual inspection, but I don't know anything about it (e.g which section should come first?) and I'm loathe to touch something I absolutely don't understand. Can someone fix the merge conflict for me?

p.s. I promise to be sliiiightly more responsive to blurb PRs in the future

@brettcannon
Copy link
Member

I've resolved the merge conflict, now we wait if Travis agrees that I didn't muck it up. 😉

@Mariatta
Copy link
Member

Tests failed ❌

@larryhastings
Copy link
Contributor

I'll wait to (re-)review until the tests pass.

@larryhastings larryhastings merged commit 6529224 into python:master May 17, 2018
@larryhastings
Copy link
Contributor

Oops! The tests didn't pass, but I hit the magic "squash and merge" button. So this work is committed!

Antoine: We're still at the PyCon sprints (last day), and we'll keep an eye on it. It seems like the Travis CI part is fine; if there are bugs, can we ping you and get another PR out of you?

@larryhastings
Copy link
Contributor

Tests fixed by #246. We have Travis CI running on blurb now! Thanks, Antoine!

@webknjaz
Copy link
Contributor

Such matrix + conditionals can become more messy and hard to read, so I've refactored it a bit in #252 according to best practices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants