-
-
Notifications
You must be signed in to change notification settings - Fork 60
Test blurb in Travis-CI #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If #146 goes in then the |
Can't cherry_picker be tested be with 3.5 as well? Or doesn't it work there? |
cherry_picker doesn't work in Python 3.5. |
This is pending fix of issue python/blurb#1 for blurb tests to actually run. |
Currently this has a conflict. I'd be happy to review it, but can you fix the conflicts first? Thanks. |
… run_blurb_tests
Ok, conflicts fixed. |
There's now a merge conflict in .travis.yml. It looks like an easy merge based on a simple visual inspection, but I don't know anything about it (e.g which section should come first?) and I'm loathe to touch something I absolutely don't understand. Can someone fix the merge conflict for me? p.s. I promise to be sliiiightly more responsive to blurb PRs in the future |
I've resolved the merge conflict, now we wait if Travis agrees that I didn't muck it up. 😉 |
Tests failed ❌ |
I'll wait to (re-)review until the tests pass. |
Oops! The tests didn't pass, but I hit the magic "squash and merge" button. So this work is committed! Antoine: We're still at the PyCon sprints (last day), and we'll keep an eye on it. It seems like the Travis CI part is fine; if there are bugs, can we ping you and get another PR out of you? |
Tests fixed by #246. We have Travis CI running on blurb now! Thanks, Antoine! |
Such matrix + conditionals can become more messy and hard to read, so I've refactored it a bit in #252 according to best practices |
No description provided.