Restore semantics of tests.

They relied (accidentally) on wait_for() creating a task,
causing the event loop to run once when calling close().

Author: aaugustin

tests/legacy/test_protocol.py

@@ -190,7 +190,6 @@ def half_close_connection_local(self, code=1000, reason="close"):
         close_frame_data = Close(code, reason).serialize()
         # Trigger the closing handshake from the local endpoint.
         close_task = self.loop.create_task(self.protocol.close(code, reason))
-        self.run_loop_once()  # wait_for executes
         self.run_loop_once()  # write_frame executes
         # Empty the outgoing data stream so we can make assertions later on.
         self.assertOneFrameSent(True, OP_CLOSE, close_frame_data)
@@ -919,6 +918,7 @@ def test_answer_ping_does_not_crash_if_connection_closing(self):
         close_task = self.half_close_connection_local()
 
         self.receive_frame(Frame(True, OP_PING, b"test"))
+        self.run_loop_once()
 
         with self.assertNoLogs():
             self.loop.run_until_complete(self.protocol.close())
@@ -931,6 +931,7 @@ def test_answer_ping_does_not_crash_if_connection_closed(self):
         # which prevents responding with a pong frame properly.
         self.receive_frame(Frame(True, OP_PING, b"test"))
         self.receive_eof()
+        self.run_loop_once()
 
         with self.assertNoLogs():
             self.loop.run_until_complete(self.protocol.close())
@@ -1362,6 +1363,7 @@ def test_remote_close_and_connection_lost(self):
         # which prevents echoing the close frame properly.
         self.receive_frame(self.close_frame)
         self.receive_eof()
+        self.run_loop_once()
 
         with self.assertNoLogs():
             self.loop.run_until_complete(self.protocol.close(reason="oh noes!"))
@@ -1375,6 +1377,7 @@ def test_simultaneous_close(self):
         # https://github.com/aaugustin/websockets/issues/339
         self.loop.call_soon(self.receive_frame, self.remote_close)
         self.loop.call_soon(self.receive_eof_if_client)
+        self.run_loop_once()
 
         self.loop.run_until_complete(self.protocol.close(reason="local"))
 
@@ -1386,6 +1389,7 @@ def test_simultaneous_close(self):
 
     def test_close_preserves_incoming_frames(self):
         self.receive_frame(Frame(True, OP_TEXT, b"hello"))
+        self.run_loop_once()
 
         self.loop.call_later(MS, self.receive_frame, self.close_frame)
         self.loop.call_later(MS, self.receive_eof_if_client)
@@ -1573,6 +1577,7 @@ def test_local_close_connection_lost_timeout_after_write_eof(self):
             # HACK: disable write_eof => other end drops connection emulation.
             self.transport._eof = True
             self.receive_frame(self.close_frame)
+            self.run_loop_once()
             self.loop.run_until_complete(self.protocol.close(reason="close"))
         self.assertConnectionClosed(1000, "close")
 
@@ -1589,6 +1594,7 @@ def test_local_close_connection_lost_timeout_after_close(self):
             # HACK: disable close => other end drops connection emulation.
             self.transport._closing = True
             self.receive_frame(self.close_frame)
+            self.run_loop_once()
             self.loop.run_until_complete(self.protocol.close(reason="close"))
         self.assertConnectionClosed(1000, "close")
 
@@ -1631,6 +1637,7 @@ def test_local_close_connection_lost_timeout_after_write_eof(self):
             # HACK: disable write_eof => other end drops connection emulation.
             self.transport._eof = True
             self.receive_frame(self.close_frame)
+            self.run_loop_once()
             self.loop.run_until_complete(self.protocol.close(reason="close"))
         self.assertConnectionClosed(1000, "close")
 
@@ -1650,5 +1657,6 @@ def test_local_close_connection_lost_timeout_after_close(self):
             # HACK: disable close => other end drops connection emulation.
             self.transport._closing = True
             self.receive_frame(self.close_frame)
+            self.run_loop_once()
             self.loop.run_until_complete(self.protocol.close(reason="close"))
         self.assertConnectionClosed(1000, "close")