Skip to content

Commit 919624f

Browse files
authored
Merge pull request #1593 from njsmith/better-newsfragment-categories
Minor overhaul of our newsfragment categories
2 parents e999e7b + 4d58d74 commit 919624f

File tree

4 files changed

+28
-13
lines changed

4 files changed

+28
-13
lines changed
File renamed without changes.
File renamed without changes.

newsfragments/README.rst

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,28 @@ relevant to people working on the code itself.)
88
Each file should be named like ``<ISSUE>.<TYPE>.rst``, where
99
``<ISSUE>`` is an issue numbers, and ``<TYPE>`` is one of:
1010

11-
* ``feature``
11+
* ``headline``: a major new feature we want to highlight for users
12+
* ``breaking``: any breaking changes that happen without a proper
13+
deprecation period (note: deprecations, and removal of previously
14+
deprecated features after an appropriate time, go in the
15+
``deprecated`` category instead)
16+
* ``feature``: any new feature that doesn't qualify for ``headline``
1217
* ``bugfix``
1318
* ``doc``
14-
* ``removal``
19+
* ``deprecated``
1520
* ``misc``
1621

17-
So for example: ``123.feature.rst``, ``456.bugfix.rst``
22+
So for example: ``123.headline.rst``, ``456.bugfix.rst``,
23+
``789.deprecated.rst``
1824

1925
If your PR fixes an issue, use that number here. If there is no issue,
2026
then after you submit the PR and get the PR number you can add a
2127
newsfragment using that instead.
2228

23-
Note that the ``towncrier`` tool will automatically
24-
reflow your text, so don't try to do any fancy formatting. You can
25-
install ``towncrier`` and then run ``towncrier --draft`` if you want
26-
to get a preview of how your change will look in the final release
27-
notes.
29+
Your text can use all the same markup that we use in our Sphinx docs.
30+
For example, you can use double-backticks to mark code snippets, or
31+
single-backticks to link to a function/class/module.
32+
33+
To check how your formatting looks, the easiest way is to make the PR,
34+
and then after the CI checks run, click on the "Read the Docs build"
35+
details link, and navigate to the release history page.

pyproject.toml

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,15 @@ directory = "newsfragments"
1515
underlines = ["-", "~", "^"]
1616
issue_format = "`#{issue} <https://github.com/python-trio/trio/issues/{issue}>`__"
1717

18-
# Unfortunately there's no way to simply override
19-
# tool.towncrier.type.misc.showcontent
18+
[[tool.towncrier.type]]
19+
directory = "headline"
20+
name = "Headline features"
21+
showcontent = true
22+
23+
[[tool.towncrier.type]]
24+
directory = "breaking"
25+
name = "Breaking changes"
26+
showcontent = true
2027

2128
[[tool.towncrier.type]]
2229
directory = "feature"
@@ -30,12 +37,12 @@ showcontent = true
3037

3138
[[tool.towncrier.type]]
3239
directory = "doc"
33-
name = "Improved Documentation"
40+
name = "Improved documentation"
3441
showcontent = true
3542

3643
[[tool.towncrier.type]]
37-
directory = "removal"
38-
name = "Deprecations and Removals"
44+
directory = "deprecated"
45+
name = "Deprecations and removals"
3946
showcontent = true
4047

4148
[[tool.towncrier.type]]

0 commit comments

Comments
 (0)