Remove use of distutils #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
+ Coverage 95.25% 95.40% +0.15%
==========================================
Files 83 83
Lines 1874 1873 -1
Branches 280 281 +1
==========================================
+ Hits 1785 1787 +2
+ Misses 68 67 -1
+ Partials 21 19 -2
Continue to review full report at Codecov.
|
p1c2u
force-pushed
the
remove-distutils
branch
2 times, most recently
from
33f0058 to
0ff412d
Compare
Distutils is going away in Python 3.12. Running tests on a project that
uses openapi-core with Python 3.10 yields the following warning:
.../openapi_core/unmarshalling/schemas/util.py:5: DeprecationWarning:
The distutils package is deprecated and slated for removal in Python
3.12. Use setuptools or check PEP 632 for potential alternatives
from distutils.util import strtobool
The offending API is really simple. Just vendor the code.
Signed-off-by: Stephen Finucane <[email protected]>
|
@stephenfin thank you for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distutils is going away in Python 3.12. Running tests on a project that uses openapi-core with Python 3.10 yields the following warning:
The offending API is really simple. Just vendor the code.
Fixes #390