Support basic re_path #337
Conversation
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 79 79
Lines 1627 1627
=======================================
Hits 1559 1559
Misses 68 68
Continue to review full report at Codecov.
|
| @@ -36,6 +36,11 @@ def create(cls, request): | |||
| else: | |||
| route = cls.path_regex.sub( | |||
| r'{\1}', request.resolver_match.route) | |||
| # Delete start marker and expression marker to allow concatenation. | |||
| if route[:1] == "^": | |||
| route = route[1:] | |||
There was a problem hiding this comment.
I failed to trigger this case into a test environment as there are side effects in testing.
There was a problem hiding this comment.
@p1c2u Can you help me with it?
There was a problem hiding this comment.
Why not just add ^ to re_path:
re_path('^test/test-regexp/$', lambda d: None)
?
There was a problem hiding this comment.
I tried to add ^/ but it didn't work. Stupid mistake. It should work now.
|
@p1c2u It is green now. |
|
@mik-laj thanks for the contribution |
Helllo.
I had a project that used a very old URL format and unfortunately, this library couldn't find the path.
It turned out that this library tries to make various concatenations and matches based on this expression which obviously failed.
https://github.com/p1c2u/openapi-core/blob/512ff6b48d105351c4be730dd78c5d7c00492db1/openapi_core/templating/paths/finders.py#L49
Close: #278
Brest regards,
Kamil Breguła