Skip to content

Add extensions support for the Parameter model #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

jparise
Copy link
Contributor

@jparise jparise commented Mar 30, 2021

Extensions are allowed on Parameter objects, per the spec:

This object MAY be extended with Specification Extensions.

https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.3.md#parameterObject

Extensions are allowed on Parameter objects, per the spec:

> This object MAY be extended with Specification Extensions.

https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.3.md#parameterObject
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #308 (4c725af) into master (098b015) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   96.80%   96.81%           
=======================================
  Files         124      124           
  Lines        2472     2479    +7     
=======================================
+ Hits         2393     2400    +7     
  Misses         79       79           
Impacted Files Coverage Δ
openapi_core/schema/parameters/factories.py 100.00% <100.00%> (ø)
openapi_core/schema/parameters/models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 098b015...4c725af. Read the comment docs.

Copy link
Collaborator

@p1c2u p1c2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p1c2u
Copy link
Collaborator

p1c2u commented Mar 31, 2021

@jparise thanks for the contribution

@p1c2u p1c2u merged commit 086e0b1 into python-openapi:master Mar 31, 2021
@jparise jparise deleted the schema-parameters-extensions branch March 31, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants