Skip to content

AnyUnmarshaller use allOf schemas #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Feb 8, 2021

Use allOf schemas to determine unmarshaller schema type for AnyUnmarshaller

Fixes #285

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #286 (c40bd4d) into master (667795d) will decrease coverage by 0.06%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage   96.81%   96.75%   -0.07%     
==========================================
  Files         122      122              
  Lines        2416     2431      +15     
==========================================
+ Hits         2339     2352      +13     
- Misses         77       79       +2     
Impacted Files Coverage Δ
...penapi_core/unmarshalling/schemas/unmarshallers.py 94.01% <86.66%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 667795d...c40bd4d. Read the comment docs.

@p1c2u p1c2u merged commit ab78913 into master Feb 9, 2021
@p1c2u p1c2u deleted the fix/any-unmarshaller-use-all-of branch February 9, 2021 22:07
@sjiekak
Copy link

sjiekak commented Feb 12, 2021

@p1c2u this change greatly improved validation performance on a schema I'm using. Were you aware of it ?

@p1c2u
Copy link
Collaborator Author

p1c2u commented Feb 12, 2021

@sjiekak
That means you have many any type schemas with allof inside. Am I right? Unmarshalling of undefined type and detecting the proper valid type could be the case.

@sjiekak
Copy link

sjiekak commented Feb 12, 2021

I'm afraid this change also introduced a bug, with some fields among the allOf schema not being validated. I will try to submit a proper issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"schema not type of Schema" error validating object containing a string array
2 participants