Issue #16: accept arbitrary buffer-compatible objects #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge development branch
Merge development branch
jonathanunderwood
requested changes
Jun 9, 2017
lz4/block/_block.c
Outdated
| PyErr_Format(PyExc_OverflowError, "input too large for C 'int'"); | ||
| return NULL; | ||
| } | ||
|
|
There was a problem hiding this comment.
Pedantic: please be consistent with error message capitalization - "Input.."
|
You're welcome. I think I've now made the changes you asked for. |
|
Also, would be super awesome if you could rebase it on top of the development branch. |
…into accept_buffer_objects
|
Ok, I think I've rebased now (actually merged). |
|
Looks like format |
|
(if I may suggest so, you could simply drop Python 3.2 or even 3.3 compatibility, I don't think anybody would notice :-)) |
|
Yup - had noticed, just hadn't gotten around to removing 3.2 from the travis and appveyor configs :) Thanks again for your work on this. |
pitrou
added a commit
to pitrou/distributed
that referenced
this pull request
Jun 9, 2017
Current versions of the lz4 binding don't support memoryview inputs, but later versions should (see python-lz4/python-lz4#38).
mrocklin
pushed a commit
to dask/distributed
that referenced
this pull request
Jun 11, 2017
* lz4: first try passing memoryview Current versions of the lz4 binding don't support memoryview inputs, but later versions should (see python-lz4/python-lz4#38). * Add tests * Add comment about blosc * always use blosc on memoryviews if available
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes hand-written checks for bytes and bytearray, and instead uses the buffer API which allows for arbitrary buffer-compatible types. This is similar to what standard library modules like
zlibalready do.Incidentally, this also makes it possible to pass in a Numpy array without copying it to a bytes object first (see #35).