Fix date format validator to allow non-str objects

Rejecting non-string data results in incorrect rejection of data in
which `string` is one of the available types and the `date-time`
format is in use.

Fixes #571

Author: sirosen

CHANGELOG.rst

@@ -9,6 +9,9 @@ Unreleased
 ----------
 
 .. vendor-insert-here
+- Fix a bug in the evaluation of the ``date-time`` format on non-string data,
+  which incorrectly rejected values for which ``string`` was one of several
+  valid types. Thanks :user:`katylava`! (:issue:`571`)
 
 0.33.1
 ------

src/check_jsonschema/formats/implementations/rfc3339.py

@@ -57,7 +57,7 @@
 def validate(date_str: object) -> bool:
     """Validate a string as a RFC3339 date-time."""
     if not isinstance(date_str, str):
-        return False
+        return True
     if not RFC3339_REGEX.match(date_str):
         return False
 

tests/example-files/explicit-schema/positive/date-format/instance.json

@@ -0,0 +1 @@
+{"some_date": null}

tests/example-files/explicit-schema/positive/date-format/schema.json

@@ -0,0 +1,12 @@
+{
+    "$schema": "https://json-schema.org/draft/2020-12/schema",
+    "type": "object",
+    "properties": {
+        "some_date": {
+            "type": ["string", "null"],
+            "format": "date-time"
+        }
+    },
+    "required": ["some_date"],
+    "additionalProperties": false
+}

tests/unit/formats/test_rfc3339.py

@@ -22,7 +22,6 @@ def test_simple_positive_cases(datestr):
 @pytest.mark.parametrize(
     "datestr",
     (
-        object(),
         "2018-12-31T23:59:59",
         "2018-12-31T23:59:59+00:00Z",
         "2018-12-31 23:59:59",