Skip to content
This repository was archived by the owner on Jan 13, 2021. It is now read-only.

Fix integration test for Python 3 #302

Merged
merged 1 commit into from
Jan 17, 2017

Conversation

laike9m
Copy link
Contributor

@laike9m laike9m commented Jan 17, 2017

Originally this two tests test_adapter_received_values and test_adapter_sending_values would fail in Python 3 due to connection header not being removed, which is a bug of the h2_safe_headers function.

headers(class HTTPHeaderMap) stores bytes because we call to_bytestring_tuple when initiating it. While in Python 2 bytes is equivalent to str, and h2_safe_headers can find 'connection' successfully, in Python 3 b'connection' != 'connection', so this header is not removed.

Some affected tests are also modified.

@Lukasa
Copy link
Member

Lukasa commented Jan 17, 2017

This looks good to me, thanks so much! ✨

@Lukasa Lukasa merged commit f8a84cf into python-hyper:development Jan 17, 2017
@laike9m
Copy link
Contributor Author

laike9m commented Jan 18, 2017

BTW how to join the Hyper organization, created certain amount of PRs?

@Lukasa
Copy link
Member

Lukasa commented Jan 18, 2017

@laike9m Strictly, this repository is not a part of the Hyper organisation yet. I appreciate that that's confusing, but for various boring organisational reasons I haven't brought it in yet. However, literally any PR against any of the projects in this org would qualify you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants