This repository was archived by the owner on Jan 13, 2021. It is now read-only.
Fix integration test for Python 3 #302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally this two tests
test_adapter_received_values
andtest_adapter_sending_values
would fail in Python 3 due toconnection
header not being removed, which is a bug of theh2_safe_headers
function.headers(class HTTPHeaderMap)
stores bytes because we callto_bytestring_tuple
when initiating it. While in Python 2bytes
is equivalent tostr
, andh2_safe_headers
can find'connection'
successfully, in Python 3b'connection' != 'connection'
, so this header is not removed.Some affected tests are also modified.