Skip to content

Commit 79efbe6

Browse files
author
Martin Panter
committed
Remove ZipFile.open() workaround for pre-2.6 Python
1 parent 64e5a17 commit 79efbe6

File tree

1 file changed

+6
-15
lines changed

1 file changed

+6
-15
lines changed

xlrd/xlsx.py

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -692,15 +692,6 @@ def bad_child_tag(child_tag):
692692
}
693693
augment_keys(tag2meth, U_SSML12)
694694

695-
def getzflo(zipfile, member_path):
696-
# GET a Zipfile File-Like Object for passing to
697-
# an XML parser
698-
try:
699-
return zipfile.open(member_path) # CPython 2.6 onwards
700-
except AttributeError:
701-
# old way
702-
return BYTES_IO(zipfile.read(member_path))
703-
704695
def open_workbook_2007_xml(
705696
zf,
706697
component_names,
@@ -727,20 +718,20 @@ def open_workbook_2007_xml(
727718
bk.ragged_rows = ragged_rows
728719

729720
x12book = X12Book(bk, logfile, verbosity)
730-
zflo = getzflo(zf, 'xl/_rels/workbook.xml.rels')
721+
zflo = zf.open('xl/_rels/workbook.xml.rels')
731722
x12book.process_rels(zflo)
732723
del zflo
733-
zflo = getzflo(zf, 'xl/workbook.xml')
724+
zflo = zf.open('xl/workbook.xml')
734725
x12book.process_stream(zflo, 'Workbook')
735726
del zflo
736727
props_name = 'docProps/core.xml'
737728
if props_name in component_names:
738-
zflo = getzflo(zf, props_name)
729+
zflo = zf.open(props_name)
739730
x12book.process_coreprops(zflo)
740731

741732
x12sty = X12Styles(bk, logfile, verbosity)
742733
if 'xl/styles.xml' in component_names:
743-
zflo = getzflo(zf, 'xl/styles.xml')
734+
zflo = zf.open('xl/styles.xml')
744735
x12sty.process_stream(zflo, 'styles')
745736
del zflo
746737
else:
@@ -750,13 +741,13 @@ def open_workbook_2007_xml(
750741
sst_fname = 'xl/sharedStrings.xml'
751742
x12sst = X12SST(bk, logfile, verbosity)
752743
if sst_fname in component_names:
753-
zflo = getzflo(zf, sst_fname)
744+
zflo = zf.open(sst_fname)
754745
x12sst.process_stream(zflo, 'SST')
755746
del zflo
756747

757748
for sheetx in range(bk.nsheets):
758749
fname = x12book.sheet_targets[sheetx]
759-
zflo = getzflo(zf, fname)
750+
zflo = zf.open(fname)
760751
sheet = bk._sheet_list[sheetx]
761752
x12sheet = X12Sheet(sheet, logfile, verbosity)
762753
heading = "Sheet %r (sheetx=%d) from %r" % (sheet.name, sheetx, fname)

0 commit comments

Comments
 (0)