Patreon #1917
Patreon #1917
Conversation
Add function to send the current supporters Add a command to call this function
|
I would also like a review from @ChrisLovering - cannot work out how to request a review from you though :-) |
Revert "Rename some variables" This reverts commit 2f5aeb0. Fix variable names (again) And again
mathstrains21
force-pushed
the
patreon
branch
from
2f5aeb0 to
68b382a
Compare
wookie184
dismissed stale reviews from TizzySaurus and themself
Changes made
wookie184
requested review from
ionite34,
Bluenix2,
minalike and
onerandomusername
and removed request for
Akarys42
|
Please remove my request for review. |
wookie184
added
s: needs review
| @commands.Cog.listener() | ||
| async def on_member_update(self, before: discord.Member, after: discord.Member) -> None: | ||
| """Send a message when someone receives a patreon role.""" | ||
| old_patreon_tier = get_patreon_tier(before) | ||
| new_patreon_tier = get_patreon_tier(after) |
There was a problem hiding this comment.
This has an inherent dependency on how the patreon bot works. If the patreon bot decided to take away and giveth the new role in two seperate api requests, this would cease to work. Or, if the patreon bot were to take the old role away and then give the new role, this would also cease to work.
This all hinges on the patreon bot making a single api request, and would lead to funky behaviour if their bot used more than one request--and I believe it does.
There was a problem hiding this comment.
I don't think this should be an issue. Whatever order things happen there will still only be one member_update that involves the tier increasing, which is all that this checks.
The only slightly unintended case would be if a user moves down a tier (e.g. from 3 to 2), and the bot does this by removing 3 and then adding 2. In this case the message would be sent, although it still wouldn't be incorrect (Just saying they are now a tier 2 patron).
Fixing this would probably require waiting for other role changes to see if they change things, although this could be fairly complicated so I think it would be best to see how what we have currently works out.
Thanks, I definitely did not forget those were things that would need to be done :P |
|
Thanks @wookie184 for finishing this off for me! |
Closes #1765
First off, this is my first pull request so please give me general pull request feedback if you have any :-)
Some decisions have been made on discord. A search of
bot#1765should find you all the conversations.Some changes to make to test:
There are 2 new commands:
!patronsand!patreon. These send the list of patrons and some patreon info respectively.Logging
I have not included an logging. Please provide feedback about logging.