Skip to content

[WIP] typing for getcfg and determine_setup #6450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[WIP] typing for getcfg and determine_setup #6450

wants to merge 3 commits into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jan 13, 2020

No description provided.

@blueyed blueyed mentioned this pull request Jan 13, 2020
Merged
@blueyed blueyed force-pushed the typing-determine_setup branch from a6986d8 to 8824a62 Compare January 13, 2020 10:35
@bluetech
Copy link
Member

Somehow some comments seem to have been lost...

Did we get a conclusion on using an empty SectionWrapper instead of the Dict? If a dict is necessary, can it be typed as Dict[str, str] instead?

@blueyed
Copy link
Contributor Author

blueyed commented Jan 14, 2020 •
edited
Loading

Somehow some comments seem to have been lost...

I've pulled this out of #6447.

Did we get a conclusion on using an empty SectionWrapper instead of the Dict? If a dict is necessary, can it be typed as Dict[str, str] instead?

Given that SectionWrapper is not importable I've found this to be less useful / possible.
Using it via py._vendored_packages now.

@blueyed blueyed changed the base branch from features to master January 17, 2020 08:10
@blueyed blueyed force-pushed the typing-determine_setup branch from 8824a62 to 3d83b1f Compare January 17, 2020 08:10
@blueyed blueyed mentioned this pull request Jan 23, 2020
Merged
@blueyed blueyed mentioned this pull request Feb 24, 2020
Closed
1 task
@blueyed blueyed force-pushed the typing-determine_setup branch from 3d83b1f to 3796ae0 Compare February 24, 2020 22:37
@bluetech
Copy link
Member

Do the py stubs change things for this PR?

In the py stubs we made SectionWrapper hidden - _SectionWrapper - because it isn't exposed in the public API (not importable).

@blueyed
Copy link
Contributor Author

blueyed commented Feb 28, 2020

@bluetech py stubs are helpful / change things.
I've worked a bit more on this in blueyed#251, but IIRC used the _vendored import also for instance checks there.

@blueyed blueyed changed the title typing for getcfg and determine_setup [WIP] typing for getcfg and determine_setup Feb 28, 2020
@bluetech
Copy link
Member

OK, feel free to ping me once this is ready.

@nicoddemus
Copy link
Member

Closing for now.

@nicoddemus nicoddemus closed this May 16, 2020
@blueyed blueyed deleted the typing-determine_setup branch November 2, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blueyed @bluetech @nicoddemus