Skip to content

Preparing release version 4.6.9 #6391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2020
Merged

Preparing release version 4.6.9 #6391

merged 1 commit into from
Jan 4, 2020

Conversation

asottile
Copy link
Member

@asottile asottile commented Jan 2, 2020

Shall we do the last core-supported python 2.x release?

@hugovk
Copy link
Member

hugovk commented Jan 2, 2020

See also #6392 to update the copyright year to 2020 for the 4.6 branch.

@nicoddemus
Copy link
Member

See also #6392 to update the copyright year to 2020 for the 4.6 branch.

You think we should re-create the release PR because of that @hugovk?

@asottile
Copy link
Member Author

asottile commented Jan 4, 2020

I'll wait until resolution 🕥

@nicoddemus
Copy link
Member

Sorry, what do you mean by "resolution"?

@asottile
Copy link
Member Author

asottile commented Jan 4, 2020

what ya'll decide on the copyright year shenanigans :)

@nicoddemus
Copy link
Member

Oh I see, thanks! 😁

@hugovk
Copy link
Member

hugovk commented Jan 4, 2020

You think we should re-create the release PR because of that @hugovk?

Legally? I have no idea.

Practically? Some of them were out of date for a few years already.

Functionally? It doesn't make much difference.

@nicoddemus
Copy link
Member

Thanks! We'll the copyright pr has been merged, so all this needs is a rebase. 👍

@nicoddemus
Copy link
Member

Thanks @asottile!

last core-supported

Perhaps this wording might be misinterpreted (if you were planning on saying something like this on twitter/announce), given that while we will no longer backport patches ourselves, we will still keep 4.6-maintenance around, and make releases based on user-provided patches.

@asottile
Copy link
Member Author

asottile commented Jan 4, 2020

ah yeah I was planning on being a little more tactful :)

@asottile asottile merged commit b39b867 into pytest-dev:4.6-maintenance Jan 4, 2020
@asottile asottile deleted the release-4.6.9 branch January 4, 2020 20:59
nicoddemus added a commit that referenced this pull request Jan 4, 2020
Merge pull request #6391 from asottile/release-4.6.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants