Skip to content

reportopts: A: put "Pp" in front #5119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Apr 14, 2019

No changelog, followup to #5068.

Have not really checked if this is sane yet, but "P" means to provide the output of the passed tests, and "p" to include it in the summary - where it should come first also then.

@blueyed blueyed force-pushed the reportopts-A-order branch from 9b9b97f to ae33279 Compare April 15, 2019 02:37
@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #5119 into features will increase coverage by 0.94%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5119      +/-   ##
============================================
+ Coverage     91.33%   92.27%   +0.94%     
============================================
  Files           115      115              
  Lines         26165    26165              
  Branches       2578     2578              
============================================
+ Hits          23897    24144     +247     
+ Misses         1940     1695     -245     
+ Partials        328      326       -2
Impacted Files Coverage Δ
src/_pytest/terminal.py 89.81% <100%> (ø) ⬆️
testing/test_terminal.py 78.38% <100%> (-3.89%) ⬇️
testing/test_tmpdir.py 75.8% <0%> (-23.12%) ⬇️
testing/python/fixtures.py 89.91% <0%> (-8.6%) ⬇️
testing/python/integration.py 86.42% <0%> (-5%) ⬇️
src/_pytest/tmpdir.py 96.55% <0%> (-3.45%) ⬇️
testing/python/metafunc.py 92.27% <0%> (-2.95%) ⬇️
src/_pytest/fixtures.py 97.79% <0%> (-0.14%) ⬇️
src/_pytest/python.py 93.09% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f7c7a9...f9f41e6. Read the comment docs.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks fine, make sure it works well before shipping 👍

@nicoddemus
Copy link
Member

Ping @blueyed to solve the conflicts

@blueyed blueyed force-pushed the reportopts-A-order branch from ae33279 to f9f41e6 Compare May 23, 2019 07:40
@blueyed blueyed merged commit 10ca84f into pytest-dev:features May 24, 2019
@blueyed blueyed deleted the reportopts-A-order branch May 24, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants