Skip to content

Discourage users from using unittest support somewhat #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2017

Conversation

ionelmc
Copy link
Member

@ionelmc ionelmc commented Jan 25, 2017

After some discussion @nedbat on IRC - he simply don't believe TestCase are bad 😜

@ionelmc ionelmc changed the title Discourage users from using this all the time. Discourage users from using unittest support somewhat Jan 25, 2017
@nicoddemus
Copy link
Member

Thanks @ionelmc!

I like the change, but I'm curious about what the discussion entailed. Also, the title talks about discouraging users from using unittest, while your comment indicates that @nedbat actually thinks it is OK to keep TestCase subclasses around.

Would love to understand better what was the discussion about. 😁

@ionelmc
Copy link
Member Author

ionelmc commented Jan 25, 2017

Well, @nedbat, what do you think of it now?

@RonnyPfannschmidt
Copy link
Member

personally i think we should put it even more harsh and ourtight say that some of us would be happy to fix those details as part of a consulting gig, but its certainly neither easy nor fun work

@ionelmc
Copy link
Member Author

ionelmc commented Jan 25, 2017

@nicoddemus the discussion was basically me saying mean things about @nedbat's testcases and bragging about converting around 40k sloc worth of testcase code to fixtures. It only took a week - what's the big deal 😁

@nicoddemus
Copy link
Member

@ionelmc thanks for the summary! 👍

Could you please take a look at the failure on the docs env?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.832% when pulling d98d122 on ionelmc-patch-1 into beb77c1 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.832% when pulling c8032a9 on ionelmc-patch-1 into beb77c1 on master.

@nicoddemus nicoddemus merged commit 0931fe2 into master Jan 25, 2017
@nicoddemus
Copy link
Member

Thanks @ionelmc!

(Just a small heads up, prefer to open PRs from your own fork, even if you have write access to the repository like you do here, otherwise CI services will run twice: once for your branch and another for the PR).

@nicoddemus nicoddemus deleted the ionelmc-patch-1 branch January 25, 2017 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants