Skip to content

Remove mention of --assert=reinterp in documentation #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rjprins
Copy link
Contributor

@rjprins rjprins commented Jan 13, 2017

Related to #1940

@RonnyPfannschmidt
Copy link
Member

thanks for working on this long overdue patch

for completeness please add an entry to changelog

@nicoddemus
Copy link
Member

Yes, thanks @rjprins.

for completeness please add an entry to changelog

You think necessary @RonnyPfannschmidt? IMHO small doc changes like this don't need a CHANGELOG entry...

@nicoddemus
Copy link
Member

(restarted Travis as most failures were related to connection issues)

@The-Compiler
Copy link
Member

I agree, no point in cluttering the changelog with stuff which likely isn't relevant to people reading it 😉

@rjprins rjprins force-pushed the remove-reinterp-from-docs branch from b34d9b5 to 46a9861 Compare January 13, 2017 21:36
@rjprins
Copy link
Contributor Author

rjprins commented Jan 13, 2017

Also updated the first paragraphs on assertion introspection which mentioned "re-evaluating".
I don't think this warrants an entry in the changelog.
Tests failed because GitHub was down.

@nicoddemus
Copy link
Member

Many thanks @rjprins!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.819% when pulling 46a9861 on rjprins:remove-reinterp-from-docs into 3dfdbaf on pytest-dev:master.

@RonnyPfannschmidt RonnyPfannschmidt merged commit 125e89b into pytest-dev:master Jan 14, 2017
@RonnyPfannschmidt
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants