Switch monkeypatch fixture to yield syntax #2173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jeffwidman, Is there a reason for this other than just improving the internal code a bit? If there are no external changes I don't think we should add a Otherwise it is a welcome mini-improvement IMO. 😁 |
The-Compiler
requested changes
Jan 4, 2017
| request.addfinalizer(mpatch.undo) | ||
| return mpatch | ||
| yield mpatch | ||
| mpatch.undo |
There was a problem hiding this comment.
This should be .undo() as we actually want to call the method now, not only pass a callable.
|
Purely internal code cleanup. Agreed there's no point in changelog. Fixed and force-pushed |
|
Thanks @jeffwidman, appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're open to merging this, let me know if I should target a different branch than master and I'll amend the commit to include updates to changelog/authors