Fix/1512 - improve truncated assertion output #1949
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part one of pytest-dev#1512. If verbosity=1, assertion explanations are truncated at 10 lines. In this situation, it's more important to tell the user which dictionary items are different than which are the same.
Part two of pytest-dev#1512. Update the format of the truncation message to help make it clear that pytest truncates the entire assertion output when verbosity < 2.
|
Looks great, just re-target to featues and then it can be merged |
|
Note you can also change the target branch of an open PR on GitHub since a few weeks: https://help.github.com/articles/changing-the-base-branch-of-a-pull-request/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve user experience for #1512. Removes common items from dictionary comparisions when verbosity=1. Also updates truncation format:
@flub let me know what you think re: the new formatting