added check for already existing option names to OptionGroup.addoption() #1645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_pytest.config.OptionGroup.addoption()
didn't care about adding the same options twice. Onlyargparse
library was later complaining about the doubled options. That made it quite difficult to find the actual root cause of issue #1618, because you couldn't get any information from the exception traceback why the doubled option adding happened. Now you can track down such issues very easily.