Skip to content

added check for already existing option names to OptionGroup.addoption() #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

userzimmermann
Copy link
Contributor

_pytest.config.OptionGroup.addoption() didn't care about adding the same options twice. Only argparse library was later complaining about the doubled options. That made it quite difficult to find the actual root cause of issue #1618, because you couldn't get any information from the exception traceback why the doubled option adding happened. Now you can track down such issues very easily.

@coveralls
Copy link

coveralls commented Jun 22, 2016

Coverage Status

Coverage increased (+0.003%) to 92.358% when pulling bb3ef0e on userzimmermann:sprint/addoption-check into a2420ce on pytest-dev:features.

@userzimmermann userzimmermann force-pushed the sprint/addoption-check branch from bb3ef0e to 69bab4a Compare June 22, 2016 16:02
@coveralls
Copy link

coveralls commented Jun 22, 2016

Coverage Status

Coverage decreased (-0.009%) to 92.389% when pulling 69bab4a on userzimmermann:sprint/addoption-check into 7d60fcc on pytest-dev:features.

@RonnyPfannschmidt RonnyPfannschmidt merged commit f2bb3df into pytest-dev:features Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants