Skip to content

Mark some xfails from #10042 as non-strict #11832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Mark some xfails from #10042 as non-strict #11832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions testing/test_debugging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ def test_pdb_prevent_ConftestImportFailure_hiding_exception(
result = pytester.runpytest_subprocess("--pdb", ".")
result.stdout.fnmatch_lines(["-> import unknown"])

@pytest.mark.xfail(reason="#10042")
@pytest.mark.xfail(reason="#10042", strict=False)
def test_pdb_interaction_capturing_simple(self, pytester: Pytester) -> None:
p1 = pytester.makepyfile(
"""
Expand Down Expand Up @@ -541,7 +541,7 @@ def function_1():
assert "BdbQuit" not in rest
assert "UNEXPECTED EXCEPTION" not in rest

@pytest.mark.xfail(reason="#10042")
@pytest.mark.xfail(reason="#10042", strict=False)
def test_pdb_interaction_capturing_twice(self, pytester: Pytester) -> None:
p1 = pytester.makepyfile(
"""
Expand Down Expand Up @@ -577,7 +577,7 @@ def test_1():
assert "1 failed" in rest
self.flush(child)

@pytest.mark.xfail(reason="#10042")
@pytest.mark.xfail(reason="#10042", strict=False)
def test_pdb_with_injected_do_debug(self, pytester: Pytester) -> None:
"""Simulates pdbpp, which injects Pdb into do_debug, and uses
self.__class__ in do_continue.
Expand Down Expand Up @@ -1022,7 +1022,7 @@ def test_1():
assert "reading from stdin while output" not in rest
TestPDB.flush(child)

@pytest.mark.xfail(reason="#10042")
@pytest.mark.xfail(reason="#10042", strict=False)
def test_pdb_not_altered(self, pytester: Pytester) -> None:
p1 = pytester.makepyfile(
"""
Expand Down Expand Up @@ -1182,7 +1182,7 @@ def test_2():


@pytest.mark.parametrize("fixture", ("capfd", "capsys"))
@pytest.mark.xfail(reason="#10042")
@pytest.mark.xfail(reason="#10042", strict=False)
def test_pdb_suspends_fixture_capturing(pytester: Pytester, fixture: str) -> None:
"""Using "-s" with pytest should suspend/resume fixture capturing."""
p1 = pytester.makepyfile(
Expand Down