Fix import_path for packages #11390
Merged
Fix import_path for packages #11390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
nicoddemus
added
the
needs backport
nicoddemus
force-pushed
the
11306-importlib-package-twice
branch
from
1ca6423 to
38a9af2
Compare
RonnyPfannschmidt
approved these changes
Sep 5, 2023
For packages, `import_path` receives the path to the package's `__init__.py` file, however module names (as they live in `sys.modules`) should not include the `__init__` part. For example, `app/core/__init__.py` should be imported as `app.core`, not as `app.core.__init__`. Fix pytest-dev#11306
nicoddemus
force-pushed
the
11306-importlib-package-twice
branch
from
38a9af2 to
9f3bdac
Compare
bluetech
approved these changes
Sep 5, 2023
nicoddemus
added
backport 7.4.x
and removed
needs backport
|
Ah, I should have followed up on the bug earlier. Now 7.4.1 is released and I have to wait longer to be unblocked 😢 |
|
@nicoddemus I believe it's not going to be a problem to trigger a release quick? |
|
I would rather wait on #11317, as that is another bug fix that we can ship. |
|
#11403 will backport that 🚀 |
|
Awesome, much appreciated! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For packages,
import_pathreceives the path to the package's__init__.pyfile, however module names (as they live insys.modules) should not include the__init__part.For example,
app/core/__init__.pyshould be imported asapp.core, not asapp.core.__init__.Fix #11306