Skip to content

Remove --boxed and pytest-forked dependency #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

nicoddemus
Copy link
Member

Fixes #468
Fixes #543

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoddemus
Copy link
Member Author

Not so simple I'm afraid... pytest-xdist's own code still uses some py functionality, such as py.log, py.local, etc.

Will go ahead and try to remove that dependency.

@asottile
Copy link
Member

looks like the py.log can be replaced pretty easily with just functools.partial(print, file=sys.stderr) (or lambda *a, **k: None in the non-debug case) -- I'll send a patch for that one

@nicoddemus
Copy link
Member Author

Yeah I was working on that.

Unfortunately just hit a wall: pytest_xdist_make_scheduler receives a py.log instance. I guess we will need a round of deprecation for that parameter. 😬

@asottile
Copy link
Member

Yeah I was working on that.

Unfortunately just hit a wall: pytest_xdist_make_scheduler receives a py.log instance. I guess we will need a round of deprecation for that parameter. 😬

I made a class which looks the same as the py.log thing -- and kept the usages the same

@nicoddemus
Copy link
Member Author

Cool.

I have some WIP replacing py.local with Path too, but I won't be able to push it in the next few hours... feel free to open a separate PR replacing py.log though.

@asottile
Copy link
Member

alrighty #822 and #823 should be good to go now I think?

@@ -0,0 +1 @@
The ``py`` dependency has been dropped.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT we no longer depend on py. 😁

@nicoddemus
Copy link
Member Author

Rebased and ready for final review.

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drop --boxed and deprecate looponfail deprecate and remove the --boxed option
3 participants