Skip to content

chore: Relax dependency constraints #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

BeyondEvil
Copy link
Contributor

No description provided.

@BeyondEvil BeyondEvil force-pushed the jim/relax-dependency-constraints branch from a135127 to 2fe8baf Compare September 25, 2022 20:46
Copy link
Member

@sallner sallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is very helpful to have this PR merged and released as the last release broke my CIs because of version constraints, which have worked before. The arguments against upper version constraints also apply for the python version and selenium here. I agree that requests might more difficult as there the version constraints are also very strict.

@BeyondEvil BeyondEvil force-pushed the jim/relax-dependency-constraints branch from 2fe8baf to 6798804 Compare September 26, 2022 17:22
@BeyondEvil
Copy link
Contributor Author

That is very helpful to have this PR merged and released as the last release broke my CIs because of version constraints, which have worked before. The arguments against upper version constraints also apply for the python version and selenium here. I agree that requests might more difficult as there the version constraints are also very strict.

THANK YOU for that link!

I spent some time yesterday trying to find best practices around dependency locking, but couldn't really find something comprehensive.

That series of blog posts was exactly what I was looking for.

Found this a little amusing:

If you write a pytest extension, however, then the chances of something breaking are much higher (but not 100%, maybe not even 50%). Quite ironically, the better a package follows SemVer, the smaller the change will trigger a major version, and therefore the less likely a major version will break a particular downstream code.

The "remedy" is obviously to run nightly tests against the main branch of pytest. Which I'm doing for pytest-html and will add here as well.

Question regarding python capping:

If I understand it correctly, if I remove the cap on python, I also have to remove it for the dependencies (like pytest-html), correct?

@sallner

Copy link
Contributor

@isaulv isaulv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follows best practice in terms of a library constraining to what's important.

@BeyondEvil BeyondEvil merged commit 47fa838 into pytest-dev:master Oct 5, 2022
@BeyondEvil BeyondEvil deleted the jim/relax-dependency-constraints branch October 5, 2022 22:33
@Crocmagnon
Copy link

I'd love to see this released! 🎉 :shipit:

@BeyondEvil BeyondEvil mentioned this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants